Bug 1507658 - Review Request: nodejs-engine-dot-io-parser - Parser for the client for the real-time Engine
Summary: Review Request: nodejs-engine-dot-io-parser - Parser for the client for the r...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-30 20:17 UTC by MartinKG
Modified: 2017-10-30 20:42 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-10-30 20:42:38 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description MartinKG 2017-10-30 20:17:49 UTC
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nodejs-engine-dot-io-parser.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nodejs-engine-dot-io-parser-2.1.1-1.fc26.src.rpm

Description: Parser for the client for the real-time Engine
Fedora Account System Username: martinkg

%changelog
* Mon Oct 30 2017 Martin Gansser <martinkg> - 2.1.1-1
- First release

$ rpmlint -iv nodejs-engine-dot-io-parser.spec /home/martin/rpmbuild/SRPMS/nodejs-engine-dot-io-parser-2.1.1-1.fc26.src.rpm /home/martin/rpmbuild/RPMS/noarch/nodejs-engine-dot-io-parser-2.1.1-1.fc26.noarch.rpm
nodejs-engine-dot-io-parser.spec: I: checking
nodejs-engine-dot-io-parser.spec: W: invalid-url Source1: tests-2.1.1.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.

nodejs-engine-dot-io-parser.spec: I: checking-url http://registry.npmjs.org/engine.io-parser/-/engine.io-parser-2.1.1.tgz (timeout 10 seconds)
nodejs-engine-dot-io-parser.src: I: checking
nodejs-engine-dot-io-parser.src: I: checking-url https://github.com/socketio/engine.io-parser (timeout 10 seconds)
nodejs-engine-dot-io-parser.src: W: invalid-url Source1: tests-2.1.1.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.

nodejs-engine-dot-io-parser.src: I: checking-url http://registry.npmjs.org/engine.io-parser/-/engine.io-parser-2.1.1.tgz (timeout 10 seconds)
nodejs-engine-dot-io-parser.noarch: I: checking
nodejs-engine-dot-io-parser.noarch: I: checking-url https://github.com/socketio/engine.io-parser (timeout 10 seconds)
nodejs-engine-dot-io-parser.noarch: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

nodejs-engine-dot-io-parser.noarch: W: dangling-symlink /usr/lib/node_modules/engine.io-parser/node_modules/after /usr/lib/node_modules/after
The target of the symbolic link does not exist within this package or its file
based dependencies.  Verify spelling of the link target and that the target is
included in a package in this package's dependency chain.

nodejs-engine-dot-io-parser.noarch: W: dangling-symlink /usr/lib/node_modules/engine.io-parser/node_modules/arraybuffer.slice /usr/lib/node_modules/arraybuffer.slice
The target of the symbolic link does not exist within this package or its file
based dependencies.  Verify spelling of the link target and that the target is
included in a package in this package's dependency chain.

nodejs-engine-dot-io-parser.noarch: W: dangling-symlink /usr/lib/node_modules/engine.io-parser/node_modules/base64-arraybuffer /usr/lib/node_modules/base64-arraybuffer
The target of the symbolic link does not exist within this package or its file
based dependencies.  Verify spelling of the link target and that the target is
included in a package in this package's dependency chain.

nodejs-engine-dot-io-parser.noarch: W: dangling-symlink /usr/lib/node_modules/engine.io-parser/node_modules/blob /usr/lib/node_modules/blob
The target of the symbolic link does not exist within this package or its file
based dependencies.  Verify spelling of the link target and that the target is
included in a package in this package's dependency chain.

nodejs-engine-dot-io-parser.noarch: W: dangling-symlink /usr/lib/node_modules/engine.io-parser/node_modules/has-binary2 /usr/lib/node_modules/has-binary2
The target of the symbolic link does not exist within this package or its file
based dependencies.  Verify spelling of the link target and that the target is
included in a package in this package's dependency chain.

2 packages and 1 specfiles checked; 0 errors, 8 warnings.

scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22813171

Comment 1 Robert-André Mauchin 🐧 2017-10-30 20:42:38 UTC
My bad, I've just realised I've already reviewed this before.

https://src.fedoraproject.org/rpms/nodejs-engine-dot-io-parser

So this is actually already packaged by Jared Smith.

It's available on Rawhide https://koji.fedoraproject.org/koji/packageinfo?packageID=25300


Note You need to log in before you can comment on or make changes to this bug.