Bug 1508056 - Rebase libmount to include mnt_unref_table()
Summary: Rebase libmount to include mnt_unref_table()
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: util-linux
Version: 7.5
Hardware: Unspecified
OS: Unspecified
Target Milestone: rc
: ---
Assignee: Karel Zak
QA Contact: qe-baseos-daemons
Depends On:
Blocks: 1481386 1507661
TreeView+ depends on / blocked
Reported: 2017-10-31 18:30 UTC by Colin Walters
Modified: 2017-11-01 15:15 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2017-11-01 14:24:23 UTC
Target Upstream Version:

Attachments (Terms of Use)

Description Colin Walters 2017-10-31 18:30:02 UTC
Newer glib2 versions require this:

checking for libmount/libmount.h... yes
checking for mnt_unref_table in -lmount... no
configure: error: *** Could not find libmount

Comment 2 Karel Zak 2017-10-31 22:34:20 UTC
Nice, I have doubts I want to rebase libmount. 

Maybe we can make some changes in glib2 code to make it compatible with the old libmount. The old version does not use reference counting, but free()-like functions. I can help with it. Where is the glib2 code?

Comment 3 Karel Zak 2017-10-31 22:37:35 UTC
BTW, libmount/src diffstat between rhel7.5 and the current upstream:

  23 files changed, 5573 insertions(+), 1848 deletions(-)

Comment 4 Colin Walters 2017-11-01 13:45:57 UTC
glib code is https://git.gnome.org/browse/glib/ (hasn't changed in probably > 10 years 😉)

OK, something like what we did for ostree:

https://github.com/ostreedev/ostree/commit/cee57a0268334d51cd312c6cdcf367bedfd3e30d ?

Comment 5 Colin Walters 2017-11-01 14:24:23 UTC
OK that was easy https://bugzilla.gnome.org/show_bug.cgi?id=789767

Comment 6 Karel Zak 2017-11-01 15:15:45 UTC
Cool :-)

Note You need to log in before you can comment on or make changes to this bug.