Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1508847 - Corrupted guest icons on client display, but not corrupted in guest screen capture
Corrupted guest icons on client display, but not corrupted in guest screen ca...
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: spice-gtk (Show other bugs)
7.4
x86_64 Linux
urgent Severity high
: rc
: ---
Assigned To: Frediano Ziglio
SPICE QE bug list
: ZStream
Depends On: 1416580
Blocks: 1532212
  Show dependency treegraph
 
Reported: 2017-11-02 07:17 EDT by Frank DeLorey
Modified: 2018-04-10 09:23 EDT (History)
16 users (show)

See Also:
Fixed In Version: spice-gtk-0.34-3.el7
Doc Type: Bug Fix
Doc Text:
Under certain circumstances, the virt-viewer interface displayed graphical elements incorrectly when displaying a Windows guest client. This update fixes the underlying code, which prevents this problem from occurring.
Story Points: ---
Clone Of: 1416580
: 1532212 (view as bug list)
Environment:
Last Closed: 2018-04-10 04:52:14 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
virt-viewer taskbar disruption (20.44 KB, image/jpeg)
2017-11-02 07:25 EDT, Frank DeLorey
no flags Details
Disruption with Themes service started (20.44 KB, image/jpeg)
2017-11-02 07:26 EDT, Frank DeLorey
no flags Details
Disruption with Themes service stopped (120.46 KB, image/jpeg)
2017-11-02 07:27 EDT, Frank DeLorey
no flags Details
Disruption with Themes service started (123.02 KB, image/jpeg)
2017-11-02 12:00 EDT, Frank DeLorey
no flags Details
Patch for RHPKG spice-gtk (3.26 KB, patch)
2017-12-30 06:22 EST, Frediano Ziglio
no flags Details | Diff


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0672 None None None 2018-04-10 04:52 EDT

  None (edit)
Comment 2 Frank DeLorey 2017-11-02 07:22:24 EDT
Customer installed a RHEL 7.4 client with the latest version of virt-viewer we supply, virt-viewer.x86_64 version 5.0-7.el7 and is seeing the issue originally reported upstream.They did not have this issue with older versions of virt-viewer.
Comment 3 Frank DeLorey 2017-11-02 07:25 EDT
Created attachment 1346979 [details]
virt-viewer  taskbar disruption
Comment 4 Frank DeLorey 2017-11-02 07:26 EDT
Created attachment 1346980 [details]
Disruption with Themes service started
Comment 5 Frank DeLorey 2017-11-02 07:27 EDT
Created attachment 1346981 [details]
Disruption with Themes service stopped
Comment 6 Frank DeLorey 2017-11-02 07:37:41 EDT
With the windows versions from the portal(s) RHV 3.6 (version 2.0-129) and RHV 4.1 (version 2.0-176) there are no problems.
Comment 7 Christophe Fergeau 2017-11-02 09:55:04 EDT
(In reply to Frank DeLorey from comment #2)
> Customer installed a RHEL 7.4 client with the latest version of virt-viewer
> we supply, virt-viewer.x86_64 version 5.0-7.el7 and is seeing the issue
> originally reported upstream.They did not have this issue with older
> versions of virt-viewer.

Any idea what "older versions of virt-viewer" correspond to exactly?

I assume the guest is Windows 7? Which driver/version is it running, and which graphics adapter is the VM configured with?

What are the spice-server/qemu versions? Is this being run on RHEV

Is there a step by step reproducer which can be used here? I tried it quickly in a win7 VM I have, stopped the themes.exe service, opened the details of some services in the service list, moved the windows around, but did not notice any corruption. So I'm missing something..

(In reply to Frank DeLorey from comment #6)
> With the windows versions from the portal(s) RHV 3.6 (version 2.0-129) and
> RHV 4.1 (version 2.0-176) there are no problems.

But virt-viewer 6.0 64bit on a Windows 7 client is apparently having the issue too?
Comment 8 Frank DeLorey 2017-11-02 11:21:39 EDT
Any idea what "older versions of virt-viewer" correspond to exactly?

A1) The version that came with RHEL 7.3 - virt-viewer-2.0-12.el7.x86_64


I assume the guest is Windows 7? Which driver/version is it running, and which graphics adapter is the VM configured with?

A2) I will check to verify this info

What are the spice-server/qemu versions? Is this being run on RHEV

A3) I will grab a sosreport from their host. This is RHEV:
rhev-guest-tools-iso-3.6-7.el6ev.noarch
rhev-hypervisor7-7.3-20170118.0.el6ev.noarch 
rhev-hypervisor7-7.3-20170424.0.el6ev.noarch
rhev-hypervisor7-7.3-20170425.0.el6ev.noarch
rhev-hypervisor7-7.3-20170615.0.el6ev.noarch
rhevm-3.6.12-0.1.el6.noarch 

Is there a step by step reproducer which can be used here? I tried it quickly in a win7 VM I have, stopped the themes.exe service, opened the details of some services in the service list, moved the windows around, but did not notice any corruption. So I'm missing something..

I think in their case stopping themes solves the problem having it enabled causes the problem.
Comment 9 Frank DeLorey 2017-11-02 11:44:22 EDT
A2) Windows 7 32bit VDI with RHEV-toolsSetup_4.1_7 (QXL driver version 6.1.0.10024 and spice-agent 4.41.5) on a RHEV 4.1 environment.
The same problem I have with a Dutch and a English Windows, on a RHEV 3.6 and a RHEV 4.1 environment.
Comment 10 Frank DeLorey 2017-11-02 11:54:58 EDT
But virt-viewer 6.0 64bit on a Windows 7 client is apparently having the issue too?

A4) Yes anything but the versions from the RHEV UI downloads. They tried upstream versions as they first noticed the issue with an IGEL thin client update that brought in the newer version of virt-viewer. They tested with a Windows client using various newer upstream versions 5,6 and 7 and they all show the same issue, whereas the versions from RHEV 3.6 and RHEV 4.1 do not have the problem. They then created a new RHEL 7.4 client and usinf the version of virt-viewer we package with RHEL 7.4 see the same issue.
Comment 11 Frank DeLorey 2017-11-02 12:00 EDT
Created attachment 1347060 [details]
Disruption with Themes service started
Comment 12 Frank DeLorey 2017-11-02 12:06:12 EDT
A3) qemu-kvm-common-rhev-2.9.0-16.el7_4.5.x86_64 
    spice-server-0.12.8-2.el7.1.x86_64 

Note they are seeing this problem in both a 3.6 and 4.1 RHEV environment.
Comment 13 Eric Baplue 2017-11-06 06:00:50 EST
I made a clone of my Windows 7 VDI and (re)installed RHEV tools 3.6.7 with exact the same result.
Comment 14 Eric Baplue 2017-11-09 02:20:48 EST
Is there any progression/news?
Comment 16 Frank DeLorey 2017-11-09 15:19:38 EST
It may require a RHEV environment as we have not tested it using non-RHEV based VMs.

Frank
Comment 24 Frediano Ziglio 2017-12-05 09:29:17 EST
They are not exactly random corruption. If you try to align the image with the darker line you'll manage to read back something. I think the black line at the beginning is the bytes between a line and the other. Something is not considering the correct stride. Looking at the line look like that the stride difference is exactly 7 pixels. It's weird that that line is greyed too. I remember there was some issues with 16 bit images with odd width. Note that Windows memory layout start from bottom to top so that line at that position is "expected" in such stride misalignment problems. I think would be worth trying a new client (like a master version or Fedora 27) and know the guest resolution (including depth).
This behaviour would make perfectly sense if the Windows rendering engine would capture an image and grey it but this way the screen capture would be corrupted too which is not the case here.

Question: If you disconnect and connect again are you getting the text right?
Comment 25 Frank DeLorey 2017-12-06 13:58:52 EST
Customer states that disconnecting/reconnecting makes no difference.

Franl
Comment 27 Frediano Ziglio 2017-12-20 12:02:41 EST
Got a local reproduction. Should not be hard to fix. Is a wrong stride adjustment.
Comment 28 Phil Turmel 2017-12-20 13:11:37 EST
"Should not be hard to fix."
This is very good news.  I will appreciate leaving this nuisance behind.
Comment 29 Frediano Ziglio 2017-12-21 11:03:06 EST
Send patch upstream at https://lists.freedesktop.org/archives/spice-devel/2017-December/041228.html.
Comment 30 Frediano Ziglio 2017-12-21 11:27:13 EST
Private build at https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=14834390.
Comment 31 Phil Turmel 2017-12-21 13:09:34 EST
(In reply to Frediano Ziglio from comment #29)
> Send patch upstream at
> https://lists.freedesktop.org/archives/spice-devel/2017-December/041228.html.

I am delighted to report that this fixes my system.  I will supply a Tested-By to the development list.
Comment 34 Frediano Ziglio 2017-12-30 06:22 EST
Created attachment 1374448 [details]
Patch for RHPKG spice-gtk

This is patch for 7.5.
Note that package does not compile for a missing spice-protocol package (not related to this patch). See https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=14848118.
No much idea about timing. Is there an Errata available?
I'm currently on holiday.
Comment 43 errata-xmlrpc 2018-04-10 04:52:14 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0672

Note You need to log in before you can comment on or make changes to this bug.