*** This bug has been marked as a duplicate of bug 1499692 ***
We spoke with the customer. We are seeing long API loading team due to non-paginate requests. We are looking to see what can be done to paginate the requests from the SUI.
- Need to back port paginating for requests / catalog section
(really anywhere that would load a lot of records)
Ooooo woops, shoulda updated here sooner, working this!! Yeah we have a bunch of explorers that could benefit from, uh, not requesting the firehose 😂 👩🏾🚒
So its nothing to see yet, but for visibility of progress and fun... https://github.com/ManageIQ/manageiq-ui-service/pull/1222
New commit detected on ManageIQ/manageiq/euwe:
Author: Jason Frey <firstname.lastname@example.org>
AuthorDate: Wed Nov 8 17:34:10 2017 -0500
Commit: Jason Frey <email@example.com>
CommitDate: Thu Nov 9 15:50:30 2017 -0500
Direct optimization of /api/services for performance
This is a HACK to optimize that particular path, but also creates an
entrypoint for other performance improvements via preloading.
app/controllers/api/base_controller/renderer.rb | 13 ++++++++++++-
app/models/picture.rb | 2 +-
app/models/service.rb | 8 ++++++--
app/models/service_template.rb | 13 +++++++------
spec/models/service_template_spec.rb | 20 +++++---------------
5 files changed, 31 insertions(+), 25 deletions(-)
For posterity, from our meeting today the course of action is going to be creating a patch with the above mentioned api modifications, IF these prove to not sufficiently address the issue, pagination will be implemented, but will require backporting of an api change that introduces subquery_count.
The PR (https://github.com/ManageIQ/manageiq/pull/16426) that improves the performance of the API used to retrieve the service list has been merged.
Please request a hotfix for this so that it can be given to the customer.
*** Bug 1510660 has been marked as a duplicate of this bug. ***
Allen/Gregg I'm putting this in POST, since the api change was already merged and a hotfix for that change was already made for different versions. The still in flight changes in SUI, https://github.com/ManageIQ/manageiq-ui-service/pull/1222, have not been merged. I'd suggest we open a new BZ for that PR and update the PR since it's too late to use this BZ for that PR. It would be very confusing if we need to create a new hotfix for this BZ for the remaining SUI work. That should be done in a new BZ.
My bad, I didn't see that the merged PR is only on euwe. At this point, I'm not quite sure what the issues are on master vs other branches. I'm hoping someone who knows will update the titles of the BZ and open new BZ to clarify which issue is fixed and which is still outstanding.
It feels like the backend api request optimizations should be fixed in this BZ and it's clones and the SUI pagination work should be done in another BZ. Shrug.
I guess this should be linked: https://github.com/ManageIQ/manageiq-ui-service/pull/1222
If/when we decide to move forward with pagination in euwe.... above is the pr url
Looks like the bot accidentally moved the status to ON_DEV
The 5.7 version of this BZ was fixed and released in 220.127.116.11 see: https://bugzilla.redhat.com/show_bug.cgi?id=1512610#c6
This issue was only reported as a problem for 5.7, not for newer versions such as master. Because we have pagination and better api defaults for limiting the number of api results on newer versions, this should not be a problem.
Oh yeh, if I respond, and clear the need info... those emails will go away...