Bug 1511139 - [RHCS 2.y] Change rocksdb_cache_size from OPT_INT to OPT_U64
Summary: [RHCS 2.y] Change rocksdb_cache_size from OPT_INT to OPT_U64
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: RADOS
Version: 2.4
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: rc
: 2.5
Assignee: Josh Durgin
QA Contact: Manohar Murthy
Aron Gunn
URL:
Whiteboard:
Depends On:
Blocks: 1536401
TreeView+ depends on / blocked
 
Reported: 2017-11-08 18:18 UTC by Mike Hackett
Modified: 2021-06-10 13:31 UTC (History)
10 users (show)

Fixed In Version: RHEL: ceph-10.2.10-9.el7cp Ubuntu: ceph_10.2.10-6redhat1xenial
Doc Type: Enhancement
Doc Text:
.The `RocksDB` cache size can now be larger than 2 GB Previously, you could not set values larger than 2 GB. Now, the value for `rocksdb_cache_size` parameter, can be set to a larger size, such as 4 GB.
Clone Of:
Environment:
Last Closed: 2018-02-21 19:46:24 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 3421351 0 None None None 2018-04-23 14:03:57 UTC
Red Hat Product Errata RHBA-2018:0340 0 normal SHIPPED_LIVE Red Hat Ceph Storage 2.5 bug fix and enhancement update 2018-02-22 00:50:32 UTC

Description Mike Hackett 2017-11-08 18:18:09 UTC
Description of problem:

When using a large value for cache size, 4GB for example, since rocksdb_cache _size is an OPT_INT we are not large enough for this value and we overflow.
 
I can verify that the rocksdb cache size is an OPT_INT in wip-rocksdb-patches-final. In the RocksDBStore code we pass that value directly into rocksdb:

auto cache = rocksdb::NewLRUCache(g_conf->rocksdb_cache_size);


Request is to use OPT_U64 to increase range and support the 4GB cache size.

Version-Release number of selected component (if applicable):
RHCS 2.4

Comment 1 Vikhyat Umrao 2017-11-09 13:31:50 UTC
In master: https://github.com/ceph/ceph/pull/13995 and luminous it is already present needs backport to the jewel release.


git tag --contains 2cd567b112037cc943d6d640be11afc7aa2208f9
v12.0.2
v12.0.3
v12.1.0
v12.1.1
v12.1.2
v12.1.3
v12.1.4
v12.2.0
v12.2.1
v13.0.0

Comment 2 Vikhyat Umrao 2017-11-09 13:44:37 UTC
upstream jewel backport for rocksdb_cache_size - https://github.com/ceph/ceph/pull/18850

This also needs to be merged into upstream jewel - https://github.com/ceph/ceph/pull/18010

Comment 5 Ken Dreyer (Red Hat) 2018-01-02 20:33:12 UTC
Josh, it looks like we need https://github.com/ceph/ceph/pull/18850 cherry-picked to ceph-2-rhel-patches to ship this for RHCEPH 2.5.

Comment 17 errata-xmlrpc 2018-02-21 19:46:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0340


Note You need to log in before you can comment on or make changes to this bug.