Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

This project is now read‑only. Starting Monday, February 2, please use Jira Cloud for all bug tracking management.

Bug 1511139

Summary:	[RHCS 2.y] Change rocksdb_cache_size from OPT_INT to OPT_U64
Product:	[Red Hat Storage] Red Hat Ceph Storage	Reporter:	Mike Hackett <mhackett>
Component:	RADOS	Assignee:	Josh Durgin <jdurgin>
Status:	CLOSED ERRATA	QA Contact:	Manohar Murthy <mmurthy>
Severity:	high	Docs Contact:	Aron Gunn <agunn>
Priority:	high
Version:	2.4	CC:	agunn, anharris, ceph-eng-bugs, dzafman, hnallurv, jdurgin, kchai, kdreyer, mmurthy, vumrao
Target Milestone:	rc	Keywords:	CodeChange
Target Release:	2.5
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	RHEL: ceph-10.2.10-9.el7cp Ubuntu: ceph_10.2.10-6redhat1xenial	Doc Type:	Enhancement
Doc Text:	.The `RocksDB` cache size can now be larger than 2 GB Previously, you could not set values larger than 2 GB. Now, the value for `rocksdb_cache_size` parameter, can be set to a larger size, such as 4 GB.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-21 19:46:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1536401

Description Mike Hackett 2017-11-08 18:18:09 UTC

Description of problem:

When using a large value for cache size, 4GB for example, since rocksdb_cache _size is an OPT_INT we are not large enough for this value and we overflow.
 
I can verify that the rocksdb cache size is an OPT_INT in wip-rocksdb-patches-final. In the RocksDBStore code we pass that value directly into rocksdb:

auto cache = rocksdb::NewLRUCache(g_conf->rocksdb_cache_size);


Request is to use OPT_U64 to increase range and support the 4GB cache size.

Version-Release number of selected component (if applicable):
RHCS 2.4

Comment 1 Vikhyat Umrao 2017-11-09 13:31:50 UTC

In master: https://github.com/ceph/ceph/pull/13995 and luminous it is already present needs backport to the jewel release.


git tag --contains 2cd567b112037cc943d6d640be11afc7aa2208f9
v12.0.2
v12.0.3
v12.1.0
v12.1.1
v12.1.2
v12.1.3
v12.1.4
v12.2.0
v12.2.1
v13.0.0

Comment 2 Vikhyat Umrao 2017-11-09 13:44:37 UTC

upstream jewel backport for rocksdb_cache_size - https://github.com/ceph/ceph/pull/18850

This also needs to be merged into upstream jewel - https://github.com/ceph/ceph/pull/18010

Comment 5 Ken Dreyer (Red Hat) 2018-01-02 20:33:12 UTC

Josh, it looks like we need https://github.com/ceph/ceph/pull/18850 cherry-picked to ceph-2-rhel-patches to ship this for RHCEPH 2.5.

Comment 17 errata-xmlrpc 2018-02-21 19:46:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0340