Bug 1517102 - Review Request: perl-Test-Mock-Time - Deterministic time & timers for event loop tests
Summary: Review Request: perl-Test-Mock-Time - Deterministic time & timers for event l...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1517099
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-24 08:26 UTC by Emmanuel Seyman
Modified: 2017-12-04 16:17 UTC (History)
2 users (show)

Fixed In Version: perl-Test-Mock-Time-0.1.6-2.fc28
Clone Of:
Environment:
Last Closed: 2017-12-04 16:17:40 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2017-11-24 08:26:20 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Mock-Time/perl-Test-Mock-Time.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Mock-Time/perl-Test-Mock-Time-0.1.6-1.fc26.src.rpm
Description:
This module replaces actual time with simulated time everywhere (core
time(), Time::HiRes, EV, AnyEvent with EV, Mojolicious, …) and provide
a way to write deterministic tests for event loop based applications
with timers.

Fedora Account System Username: eseyman
Rpmlint Outout:
perl-Test-Mock-Time.src: W: spelling-error %description -l en_US HiRes -> Hires, Hines, Hies
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

Comment 1 Jitka Plesnikova 2017-11-28 09:26:34 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires 
FIX: Please add constrain to perl(Module::Build::Tiny) >= 0.034
FIX: Please add following buildrequires:
   - perl(bignum) - lib/Test/Mock/Time.pm
   - perl(Carp) - lib/Test/Mock/Time.pm
   - perl(constant) - lib/Test/Mock/Time.pm
   - perl(strict) - Build.PL:2
   - perl(Time::HiRes) - t/Time::HiRes.t
   - perl(utf8) - lib/Test/Mock/Time.pm
   - perl(warnings) - Build.PL:3
   - uncomment BR perl(Export::Attrs)
TODO: If you want to run some optional tests, please add also
   - perl(AnyEvent)
   - perl(EV)
   - perl(Mojolicious) >= 6
   - perl(Mojo::IOLoop)

$ rpm -qp --requires perl-Test-Mock-Time-0.1.6-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(bignum)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Export::Attrs)
      1 perl(List::Util)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Test::MockModule)
      1 perl(utf8)
      1 perl(:VERSION) >= 5.10.1
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Mock-Time-0.1.6-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(Test::Mock::Time) = 0.1.6
      1 perl-Test-Mock-Time = 0.1.6-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Test-Mock-Time*
perl-Test-Mock-Time.noarch: W: spelling-error %description -l en_US HiRes -> Hires, Hines, Hies
perl-Test-Mock-Time.src: W: spelling-error %description -l en_US HiRes -> Hires, Hines, Hies
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

FIX: Please move LICENSE from %docs to %license.

Please correct all 'FIX' issues and consider fixing 'TODO' items.

Otherwise, the package looks good.
Approved.

Comment 2 Emmanuel Seyman 2017-11-28 13:10:14 UTC
Wow, that was a placeholder package that was not at ready for primetime. I'm surprised it did that well.

I've taken into account your feedback and enabled optional tests (which require Test::Perl::Critic and Test::Distribution).

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Mock-Time/perl-Test-Mock-Time.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Mock-Time/perl-Test-Mock-Time-0.1.6-2.fc26.src.rpm

Comment 3 Gwyn Ciesla 2017-11-28 14:02:52 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Mock-Time


Note You need to log in before you can comment on or make changes to this bug.