Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1518907

Summary:	[RFE] [CodeChange] Deprecate and update UI plugin features / attributes that changed in 4.2
Product:	[oVirt] ovirt-engine	Reporter:	Greg Sheremeta <gshereme>
Component:	Frontend.WebAdmin	Assignee:	Vojtech Szocs <vszocs>
Status:	CLOSED DUPLICATE	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.2.0	CC:	bugs, tjelinek, ylavi
Target Milestone:	ovirt-4.3.0	Keywords:	CodeChange, FutureFeature
Target Release:	---	Flags:	rule-engine: ovirt-4.3+ rule-engine: planning_ack? rule-engine: devel_ack? rule-engine: testing_ack?
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-15 07:34:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	UX	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Greg Sheremeta 2017-11-29 18:14:59 UTC

Description of problem:
[UI] Deprecate and update UI plugin features / attributes that changed in 4.2

Version-Release number of selected component (if applicable):
4.2

In 4.2, we have some slight UI plugin changes. For example, 'alignRight' no longer works.

We should find and mark such things as deprecated and update the documentation.

Comment 1 Vojtech Szocs 2017-11-30 18:32:41 UTC

(In reply to Greg Sheremeta from comment #0)
> For example, 'alignRight' no longer works.

Does PatternFly allow aligning tabs to the right side?

https://www.patternfly.org/pattern-library/widgets/#tabs

If not, we should remove the `alignRight` option and related code. If yes, that bug should be fixed.

Comment 2 Vojtech Szocs 2017-11-30 18:34:38 UTC

More things to cover and update as needed:

* taking out the word "Tab" out of function names, since the UI concept of "main tab" is no more

* support adding buttons inside kebab drop-down, as opposed to adding them directly to the toolbar

* support adding secondary level menu items when adding new "main tab" (this should become "add menu item" function)

* support customizing the icon for primary menu items

Also, encourage UI plugin authors to reuse PatternFly styling bits via the branding infra used by WebAdmin.

Comment 3 Greg Sheremeta 2017-11-30 18:35:39 UTC

(In reply to vszocs from comment #1)
> (In reply to Greg Sheremeta from comment #0)
> > For example, 'alignRight' no longer works.
> 
> Does PatternFly allow aligning tabs to the right side?
> 
> https://www.patternfly.org/pattern-library/widgets/#tabs
> 
> If not, we should remove the `alignRight` option and related code. If yes,
> that bug should be fixed.

I think it's ugly and we shouldn't float them right.

Comment 4 Tomas Jelinek 2018-03-15 07:34:44 UTC


*** This bug has been marked as a duplicate of bug 1553902 ***