WebAdmin UI plugin API should be updated to reflect the current UI design. 1. add functions to deal with nav menu items: a) add new primary item that doesn't hold any secondary items (=> adds new place) b) add new primary item that is supposed to hold secondary items (visible only if there's at least one secondary item contained within) c) add new secondary item into the given primary item; support existing/core primary items as well as ones created via 1.b) (=> adds new place) 2. reconcile function names/signatures to be consistent and meaningful by adding new functions - replace "tab" with "place" where appropriate 3. for existing functions that are deprecated by 2. - those should be preserved for backwards compatibility - calling those functions should log a warning in browser console, for example: "addMainTab is deprecated, please use xx or yy instead." In addition, UI plugins feature page should be updated to reflect the current state.
*** Bug 1518907 has been marked as a duplicate of this bug. ***
doc-text updated, it's ready for review.
Created attachment 1408530 [details] UI plugin to test changes
Verified in ovirt-engine-4.3.2.1-0.1.el7.noarch ovirt-engine-webadmin-portal-4.3.2.1-0.1.el7.noarch 1. All regression Webadmin tests passed. 2. The test plugin in attachment 1408530 [details] loaded without problems and works properly, i.e., the extra menu items were added using the new methods with "place" instead of "tab" in the name. Also now there are deprecation warnings in the browser console, for example: - "addSubTab is deprecated, please use addDetailPlace instead." - "setTabAccessible is deprecated, please use setPlaceAccessible instead." ...
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.