Bug 1519096 – "Context Dir" and "Git Reference" are empty when clicking "advanced options" after clicking "Try Sample Repository"

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1519096 - "Context Dir" and "Git Reference" are empty when clicking "advanced options" after clicking "Try Sample Repository"

Summary:	"Context Dir" and "Git Reference" are empty when clicking "advanced options" ...

Status:	CLOSED ERRATA

Aliases:	None

Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Management Console (Show other bugs)
Sub Component:
Version:	3.7.1
Hardware:	Unspecified Unspecified

Priority	medium Severity medium
Target Milestone:	---
Target Release:	3.7.z
Assigned To:	Samuel Padgett
QA Contact:	Yadan Pei
Docs Contact:

URL:
Whiteboard:
Keywords:

Duplicates:	1527638 (view as bug list)
Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-11-30 01:33 EST by Takayoshi Tanaka
Modified:	2018-04-05 05:33 EDT (History)
CC List:	8 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:	Previously, the sample Git reference and context dir for building images sample repositories was not used when clicking the "Try Sample Repository" link in the web console add to project dialog. The sample reference and context dir are now properly set in the build config that is created when the sample is used.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-04-05 05:33:10 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
image1 (36.80 KB, image/png) 2017-11-30 01:34 EST, Takayoshi Tanaka	no flags	Details
image2 (54.77 KB, image/png) 2017-11-30 01:34 EST, Takayoshi Tanaka	no flags	Details
image3 (45.60 KB, image/png) 2017-11-30 01:34 EST, Takayoshi Tanaka	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2018:0636	None	None	None	2018-04-05 05:33 EDT

Groups: None (edit)

Description Takayoshi Tanaka 2017-11-30 01:33:05 EST

Description of problem:
"Context Dir" and "Git Reference" are empty when clicking "advanced options" after clicking "Try Sample Repository"

Version-Release number of selected component (if applicable):
# oc version 
oc v3.7.9
kubernetes v1.7.6+a08f5eeb62
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://ose37-master:8443
openshift v3.7.9
kubernetes v1.7.6+a08f5eeb62


How reproducible:
Always

Steps to Reproduce:
1. Click "Add to project" and "Browse Catalog"
2. Click ".NET Core Builder Images 2.0" (or another template which has a sample repository)
3. Click Next
4. [attached image1] Click "Try Sample Repository", application name and git URL are filled.
5. Click "advanced options"


Actual results:
[attached image2] 
"Git Reference" and "Context Dir" are empty. 

For .NET Core 2.0 s2i image, Git Reference should be "dotnetcore-2.0" and "Context Dir" should be "app". (see attached image3)

Once the user clicked "Try Sample Repository" at the dialog (image1), Web console no longer provides "Git Reference" and "Context Dir"

Expected results:
"Git Reference" and "Context Dir" are filled with the valid values.


Additional info:

Comment 1 Takayoshi Tanaka 2017-11-30 01:34 EST

Created attachment 1360686 [details]
image1

Comment 2 Takayoshi Tanaka 2017-11-30 01:34 EST

Created attachment 1360687 [details]
image2

Comment 3 Takayoshi Tanaka 2017-11-30 01:34 EST

Created attachment 1360688 [details]
image3

Comment 4 Samuel Padgett 2017-11-30 12:41:31 EST

https://github.com/openshift/origin-web-catalog/pull/576

Comment 5 Samuel Padgett 2017-11-30 15:38:23 EST

enterprise-3.7 catalog PR: https://github.com/openshift/origin-web-catalog/pull/579

Comment 6 Samuel Padgett 2017-12-01 13:53:50 EST

3.7.z console PR:

https://github.com/openshift/origin-web-console/pull/2551

Comment 8 Yadan Pei 2017-12-06 01:47:59 EST

v3.7.13 doesn't include the changes yet, will check in next update

Comment 9 Yadan Pei 2017-12-07 21:49:54 EST

Change to MODIFIED since fix not picked in OCP, and it couldn't be tested

Comment 13 Samuel Padgett 2017-12-20 10:41:01 EST

*** Bug 1527638 has been marked as a duplicate of this bug. ***

Comment 17 Yadan Pei 2018-03-01 01:23:05 EST

Issue reported in this bug has been fixed in v3.7.35(OCP v3.9.1 also has the fix)

Clicking "Try Sample Repository" in catalog wizard could fill "Context Dir" and "Git Reference" correctly if an imagestream has.

Move to VERIFIED

Comment 21 errata-xmlrpc 2018-04-05 05:33:10 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0636

Note You need to log in before you can comment on or make changes to this bug.