Bug 1529052 - [RHV] VM\Template name&description max limit, in VM lifecycle operations dialog, do not match RHV limit
Summary: [RHV] VM\Template name&description max limit, in VM lifecycle operations dial...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: GA
: 5.10.0
Assignee: Moti Asayag
QA Contact: Angelina Vasileva
URL:
Whiteboard: rhev:vm name, description
Depends On:
Blocks: 1531292
TreeView+ depends on / blocked
 
Reported: 2017-12-26 07:16 UTC by Ilanit Stein
Modified: 2019-08-01 12:02 UTC (History)
9 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1531292 (view as bug list)
Environment:
Last Closed: 2018-06-21 20:33:00 UTC
Category: Bug
Cloudforms Team: RHEVM
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Ilanit Stein 2017-12-26 07:16:39 UTC
Description of problem:
For VM lifecycle operations [1] the VM\Template Name & description max limit do not match the RHV max limit:

VM/Template Name -        RHV:  64 chars, CFME:  40 chars
VM/Template Description - RHV: 255 chars, CFME: 100 chars

[1] VM provision from a template/Publish VM to a template/Clone Template to a VM 

Version-Release number of selected component (if applicable):
CFME-5.9.0.14/RHV-4.1.8

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Oved Ourfali 2017-12-27 06:15:06 UTC
Adam, any chance those can be increased on the CFME side?

Comment 3 Greg McCullough 2018-01-02 21:44:43 UTC
Ilanit - For the VM name issue can you provide more information or an environment to reproduce?  I was unable to recreate in my local env and I cannot recall anywhere we limit the VM name.

The description length is defined in the dialog.yaml file:

https://github.com/ManageIQ/manageiq/blob/master/product/dialogs/miq_dialogs/miq_provision_redhat_dialogs_template.yaml#L290-L296

and needs to be changed in all the redhat dialogs:
  product/dialogs/miq_dialogs/miq_provision_redhat_dialogs_template.yaml
  product/dialogs/miq_dialogs/miq_provision_redhat_dialogs_clone_to_vm.yaml
  product/dialogs/miq_dialogs/miq_provision_redhat_dialogs_clone_to_template.yaml

Comment 4 Ilanit Stein 2018-01-03 06:32:01 UTC
VM Name limitation is not mentioned in the dialog.
It is mentioned when the Request fails, in evm.log:

[----] I, [2017-12-12T03:48:17.017853 #23038:869994]  INFO -- : Calling Create Notification type: automate_user_error subject type: MiqRequest id: 5 options: {:message=>"VM Provision Error: [EVM] VM [wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd] Step [CheckProvisioned] Status [Error Creating Template] Message [[OvirtSDK4::Error]: Fault reason is \"Operation Failed\". Fault detail is \"[VM Template name must not exceed 40 characters, Attribute: _name]\". HTTP response code is 400.] "}
[----] E, [2017-12-12T03:48:17.038525 #23038:869994] ERROR -- : <AEMethod update_provision_status> VM Provision Error: [EVM] VM [wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd] Step [CheckProvisioned] Status [Error Creating Template] Message [[OvirtSDK4::Error]: Fault reason is "Operation Failed". Fault detail is "[VM Template name must not exceed 40 characters, Attribute: _name]". HTTP response code is 400.]


See also related bug:
Bug 1529080 - "VM Lifecycle" Request last message do not indicate actual problem-invalid vm name

Comment 7 Moti Asayag 2018-01-03 08:49:14 UTC
The limitation on RHV for template name was increased in ovirt-engine-4.2 to 255 chars (see bug 1416306)

Before ovirt-engine-4.2, it was 40 chars.

Vm Name, Vm description and Template description limits on RHV are 255 chars.

As Greg suggested, those limits should be updated on RHV dialog files.
I suggest will increase all to 255, expect of Template Name which should be limited to 40 (so we won't require to add version specific logic).

Comment 9 CFME Bot 2018-01-04 14:45:48 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/1f2a123af834da21758d99644cabd82b7adf9fee

commit 1f2a123af834da21758d99644cabd82b7adf9fee
Author:     Moti Asayag <masayag>
AuthorDate: Wed Jan 3 17:03:17 2018 +0200
Commit:     Moti Asayag <masayag>
CommitDate: Thu Jan 4 15:30:40 2018 +0200

    Set limits for VM and Template names and descriptions
    
    RHV enforce the following limits:
    * VM name to 255 characters
    * VM description to 255 characters
    * Template name to 40 characters (it will be extended to 255 in
    ovirt-engine-4.2)
    * Template description to 255 characters
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1529052

 .../miq_dialogs/miq_provision_redhat_dialogs_clone_to_template.yaml   | 4 ++--
 .../dialogs/miq_dialogs/miq_provision_redhat_dialogs_clone_to_vm.yaml | 4 ++--
 .../dialogs/miq_dialogs/miq_provision_redhat_dialogs_template.yaml    | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

Comment 10 CFME Bot 2018-01-04 14:48:52 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/1f2a123af834da21758d99644cabd82b7adf9fee

commit 1f2a123af834da21758d99644cabd82b7adf9fee
Author:     Moti Asayag <masayag>
AuthorDate: Wed Jan 3 17:03:17 2018 +0200
Commit:     Moti Asayag <masayag>
CommitDate: Thu Jan 4 15:30:40 2018 +0200

    Set limits for VM and Template names and descriptions
    
    RHV enforce the following limits:
    * VM name to 255 characters
    * VM description to 255 characters
    * Template name to 40 characters (it will be extended to 255 in
    ovirt-engine-4.2)
    * Template description to 255 characters
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1529052

 .../miq_dialogs/miq_provision_redhat_dialogs_clone_to_template.yaml   | 4 ++--
 .../dialogs/miq_dialogs/miq_provision_redhat_dialogs_clone_to_vm.yaml | 4 ++--
 .../dialogs/miq_dialogs/miq_provision_redhat_dialogs_template.yaml    | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.