Bug 1531292 - [RHV] VM\Template name&description max limit, in VM lifecycle operations dialog, do not match RHV limit
Summary: [RHV] VM\Template name&description max limit, in VM lifecycle operations dial...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: GA
: 5.9.0
Assignee: Moti Asayag
QA Contact: Radim Hrazdil
URL:
Whiteboard: rhev:vm name, description
Depends On: 1529052
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-04 22:55 UTC by Satoe Imaishi
Modified: 2018-03-06 15:20 UTC (History)
11 users (show)

Fixed In Version: 5.9.0.16
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1529052
Environment:
Last Closed: 2018-03-06 15:20:56 UTC
Category: ---
Cloudforms Team: RHEVM
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 2 CFME Bot 2018-01-04 23:00:55 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/0ae390bc3049e2121a125b8b48dc49eb659a514f

commit 0ae390bc3049e2121a125b8b48dc49eb659a514f
Author:     Greg McCullough <gmccullo>
AuthorDate: Thu Jan 4 09:40:55 2018 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Jan 4 17:55:33 2018 -0500

    Merge pull request #16736 from masayag/vm_template_limits
    
    Set limits for VM and Template names and descriptions
    (cherry picked from commit bf689eba47174db57344d593e53bb3cf28677c95)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531292

 .../miq_dialogs/miq_provision_redhat_dialogs_clone_to_template.yaml   | 4 ++--
 .../dialogs/miq_dialogs/miq_provision_redhat_dialogs_clone_to_vm.yaml | 4 ++--
 .../dialogs/miq_dialogs/miq_provision_redhat_dialogs_template.yaml    | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

Comment 3 Radim Hrazdil 2018-01-15 08:37:08 UTC
VM/Template name was suggested by Greg to stay limited to 40 chars on CFME side to avoid RHV version specific logic, but in the commit [1] VM/template Name was also updated to 255 chars limit. 
As Ilanit specifies in the first comment, RHV limits VM/template name to 64 chars, so attempt to provision VM with name longer than 64 chars fails.

[1] https://github.com/ManageIQ/manageiq/commit/0ae390bc3049e2121a125b8b48dc49eb659a514f

Comment 4 Greg McCullough 2018-01-15 14:22:45 UTC
Radim - As discussed here https://github.com/ManageIQ/manageiq/pull/16736#issuecomment-355107499 I suggested that we use the larger value now as that will be the supported value going forward.

If a user has a need to enforce the 64 character limit they can do that by modifying the dialog to meet their needs.  This option has been available for a long time in the dialogs.

Comment 5 Radim Hrazdil 2018-01-16 07:36:26 UTC
Greg - Thank you for explaining.

Verified in RHV 4.1.8, CFME 5.9.0.16 that VM/Template name/description is updated to 255 chars.


Note You need to log in before you can comment on or make changes to this bug.