Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1530520

Summary: Fail to upgrade due to openshift_client_binary is undefined
Product: OpenShift Container Platform Reporter: liujia <jiajliu>
Component: Cluster Version OperatorAssignee: Vadim Rutkovsky <vrutkovs>
Status: CLOSED CURRENTRELEASE QA Contact: liujia <jiajliu>
Severity: high Docs Contact:
Priority: high    
Version: 3.9.0CC: aos-bugs, jokerman, mifiedle, mmccomas, smunilla, wmeng
Target Milestone: ---   
Target Release: 3.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openshift-ansible-3.9.0-0.20.0.git.0.dce44f0.el7.noarch Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1531400 (view as bug list) Environment:
Last Closed: 2018-06-13 14:49:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1525340, 1531400    

Description liujia 2018-01-03 08:32:40 UTC
Description of problem:
Upgrade ocp from v3.7 to v3.9 failed at task [Upgrade all storage].

TASK [Upgrade all storage] **************************************************************************************************************************************************
fatal: [x.x.x.x]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'openshift_client_binary' is undefined\n\nThe error appears to have been in '/usr/share/ansible/openshift-ansible/playbooks/common/openshift-cluster/upgrades/upgrade_control_plane.yml': line 26, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n  tasks:\n  - name: Upgrade all storage\n    ^ here\n\nexception type: <class 'ansible.errors.AnsibleUndefinedVariable'>\nexception: 'openshift_client_binary' is undefined"}


Version-Release number of the following components:
openshift-ansible-3.9.0-0.13.0.git.0.8119a5c.el7.noarch
ansible-2.4.2.0-1.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. Run upgrade playbook against rpm installed ocp.
# ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_9/upgrade.yml
2.
3.

Actual results:
Upgrade failed.

Expected results:
Upgrade succeed.

Additional info:
Please attach logs from ansible-playbook with the -vvv flag

Comment 1 liujia 2018-01-03 08:33:24 UTC
Block v3.9 upgrade test

Comment 2 Scott Dodson 2018-01-05 14:24:10 UTC
I ran into this problem while working on the 3.7 to 3.9 upgrade. I'll fix it in my PR for that work soon, should have that work wrapped up today.

Comment 3 Scott Dodson 2018-01-09 16:26:38 UTC
https://github.com/openshift/openshift-ansible/pull/6634 vadim fixed this

Comment 4 Weihua Meng 2018-01-13 13:14:45 UTC
Fixed in openshift-ansible-3.9.0-0.17.0.git.0.aa1c22d.el7.noarch
Please move it ON_QA.

Comment 5 liujia 2018-01-16 10:10:48 UTC
Version:
openshift-ansible-3.9.0-0.20.0.git.0.dce44f0.el7.noarch


Steps:
1. Run upgrade playbook against rpm installed ocp.
# ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_9/upgrade.yml

Result:
Upgrade failed

For this bug, task [Upgrade all storage] has passed, so the issue has fixed. upgrade failed because another issue[1534905] which has been tracked.