Red Hat Bugzilla – Bug 153079
inappropriate strcpy in unix2dos on garbage pointer
Last modified: 2007-11-30 17:07:17 EST
Description of problem:
in version 2.2 of unix to dos in the ConvertUnixToDosNewFile function there is a
call to strcpy on line 250 to an unset pointer on the stack. Since the pointer
is unset this can lead to unpredictable results. Additionally the strcpy is no
longer needed as the MakeTempFileFrom sets the pointer in question
appropriately. I've attached a patch to correct this.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
Potential sigsegv, or data corruption
No sigsegv or data corruption
This problem was discovered in relation to IT69278, in which the reporter
discovered that by trying to convert a certain ELF file (I'm not sure why they
tried this) they received a sigsegv.
Created attachment 112580 [details]
patch to remove unneeded strcpy
Thanks. Fixed in CVS.
*** Bug 140979 has been marked as a duplicate of this bug. ***
*** Bug 145167 has been marked as a duplicate of this bug. ***
I'm a little unhappy bug #145167 was forward duped but never mind (I guess RHEL
reports matter more). Anyway will the specfile be fixed up to generate a useful
debuginfo and will the warning patch also be applied?
*** Bug 163828 has been marked as a duplicate of this bug. ***
*** Bug 164543 has been marked as a duplicate of this bug. ***
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.