RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1533810 - default value for lacp runner.sys_prio should be 65535 not 256
Summary: default value for lacp runner.sys_prio should be 65535 not 256
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: NetworkManager
Version: 7.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Francesco Giudici
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks: 1533813
TreeView+ depends on / blocked
 
Reported: 2018-01-12 09:52 UTC by Vladimir Benes
Modified: 2018-04-10 13:37 UTC (History)
8 users (show)

Fixed In Version: NetworkManager-1.10.2-11.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1533813 (view as bug list)
Environment:
Last Closed: 2018-04-10 13:35:58 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0778 0 None None None 2018-04-10 13:37:11 UTC

Description Vladimir Benes 2018-01-12 09:52:50 UTC
Description of problem:
default value is 65535 not 255 as stated in nmcli (and probably in teamd.conf too)

Version-Release number of selected component (if applicable):
1.10.2

nmcli con add type team con-name team0 ifname nm-team autoconnect no team.runner lacp yes connection.autoconnect-slaves yes

vbenes@localhost:~$ sudo teamdctl nm-team state dump
{
    "runner": {
        "active": true,
        "fast_rate": false,
        "select_policy": "lacp_prio",
        "sys_prio": 65535

but
vbenes@localhost:~$ nmcli connection show team |grep 'team.runner-sys-prio'
team.runner-sys-prio:                   255 (default)

Comment 1 Vladimir Benes 2018-01-12 10:02:04 UTC
Do please restore default when entering empty value! 0 is somehow unexpected.

Comment 2 Vladimir Benes 2018-01-12 10:35:40 UTC
(In reply to Vladimir Benes from comment #1)
> Do please restore default when entering empty value! 0 is somehow unexpected.

filed separately as bug 1533830

Comment 3 Francesco Giudici 2018-01-12 17:48:02 UTC
Pushed fix on branch: fg/team_sys_prio_default-rh1533810

please review.

Comment 4 Thomas Haller 2018-01-15 08:35:22 UTC
lgtm.

This probably should be backported for 7.5, because changing a default-value is a change in behavior. We don't want to release 7.5 with the wrong behavior and change it later. I guess, we care slightly less that we just released 1.10.2 with a different behaviour.

Comment 5 Francesco Giudici 2018-01-18 18:00:07 UTC
(In reply to Thomas Haller from comment #4)
> lgtm.
> 
> This probably should be backported for 7.5, because changing a default-value
> is a change in behavior. We don't want to release 7.5 with the wrong
> behavior and change it later. I guess, we care slightly less that we just
> released 1.10.2 with a different behaviour.

Sure, we want this in 7.5.
Please note anyway that the default value of runner.sys_prio is in any case  65535. What is wrong is that NM reports it as 255: so, if no value is specified, NM shows 255 but 65535 is set.
This implies also that it is not possible to set it to 255 as NM will remove it from the configuration, ending up having 65535.

Merged upstream
master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=345d34b36995103ca173f1a3ff07d02400c5d5f6
nm-1-10: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=ba7c7c8402fa75a7e56a4aa44e1cb16429a083d5

Comment 9 errata-xmlrpc 2018-04-10 13:35:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0778


Note You need to log in before you can comment on or make changes to this bug.