Bug 1537495 - dialogs - 'undefined' warning message headline and ''' instead of apostrophe in the description
Summary: dialogs - 'undefined' warning message headline and ''' instead of apostro...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.1.2
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.2
: ---
Assignee: Alexander Wels
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
: 1536344 1536834 1537456 1538337 1539387 1544299 1554857 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-23 11:38 UTC by Avihai
Modified: 2018-04-18 07:30 UTC (History)
11 users (show)

Fixed In Version: ovirt-engine-4.2.2.4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-29 11:13:54 UTC
oVirt Team: UX
Embargoed:
tjelinek: ovirt-4.2?
tjelinek: planning_ack?
tjelinek: devel_ack+
lsvaty: testing_ack+


Attachments (Terms of Use)
volume dialog (15.50 KB, image/png)
2018-02-21 13:40 UTC, Lucie Leistnerova
no flags Details
export template confirmation (23.70 KB, image/png)
2018-03-06 10:38 UTC, Lucie Leistnerova
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 86803 0 master MERGED webadmin: Confirmation dialog 2018-01-27 15:29:17 UTC
oVirt gerrit 88125 0 master MERGED webadmin: Confirm note 2018-02-26 19:21:24 UTC
oVirt gerrit 88268 0 ovirt-engine-4.2 MERGED webadmin: Confirm note 2018-02-28 09:51:40 UTC
oVirt gerrit 88555 0 master MERGED webadmin: Fix confirm message <br> 2018-03-06 18:29:04 UTC
oVirt gerrit 88559 0 ovirt-engine-4.2 MERGED webadmin: Fix confirm message <br> 2018-03-06 21:24:28 UTC

Description Avihai 2018-01-23 11:38:06 UTC
Description of problem:
Webadmin- Edit Logical Network window-> change anything(I change MTU to 9000) & press OK -> you get a popup message, in this message, there are 2 issues:

1)The Headline of the message is 'undefined'

2)In the message itself, several char's in the word 'isn&#39t' that are not supposed to be there '&#39' that looks like a Unicode representation of the APOSTROPHE "'" character.

See Print screen with both the issues.

Version-Release number of selected component (if applicable):
4.2.1.2-0.1

How reproducible:
100%

Steps to Reproduce:
Webadmin- Edit Logical Network window-> change anything(I change MTU to 9000) & press OK

Actual results:
you get a popup message, in this message, there are 2 issues:

1)The Headline of the message is 'undefined'

2)In the message itself, several char's in the word 'isn&#39t' that are not supposed to be there '&#39' that looks like a Unicode representation of the APOSTROPHE "'" character.


Expected results:


Additional info:
See Print screen with both the issues.

Comment 1 Tomas Jelinek 2018-01-24 08:45:40 UTC
considering we have a similar issue:
https://bugzilla.redhat.com/show_bug.cgi?id=1537456 - I guess that if the "message" part of the model contains an apostrophe, it is shown escaped in the confirm model.

Comment 2 Tomas Jelinek 2018-01-24 08:46:15 UTC
*** Bug 1537456 has been marked as a duplicate of this bug. ***

Comment 3 Greg Sheremeta 2018-01-27 16:43:32 UTC
*** Bug 1536834 has been marked as a duplicate of this bug. ***

Comment 4 Greg Sheremeta 2018-01-27 16:44:36 UTC
*** Bug 1536344 has been marked as a duplicate of this bug. ***

Comment 5 Greg Sheremeta 2018-01-27 16:58:05 UTC
*** Bug 1538337 has been marked as a duplicate of this bug. ***

Comment 6 Greg Sheremeta 2018-01-30 17:29:38 UTC
*** Bug 1539387 has been marked as a duplicate of this bug. ***

Comment 7 Lucie Leistnerova 2018-02-21 13:40:23 UTC
Title is 'Confirm', apostrophe is ok, but <br> is still visible in other dialog, see attachment

Steps to reproduce:
1. have gluster node added in engine and Up
2. create new volume (could be Distribute)
3. start the volume, volume running, bricks are up
4. stop the volume, confirmation dialog appears

tested in ovirt-engine-webadmin-portal-4.2.2-0.1.el7.noarch

Comment 8 Lucie Leistnerova 2018-02-21 13:40:55 UTC
Created attachment 1398729 [details]
volume dialog

Comment 9 Lucie Leistnerova 2018-03-06 10:37:26 UTC
I found other <br> occurance. Both texts in message and note should keep the new line. Now it removed the new line in the volume's Note from Comment 7.

Steps to reproduce:
1. create template
2. create it's subversion
3. have active export domain, export the subversion template
4. confirmation dialog appears, see attachment

Tested in ovirt-engine-webadmin-portal-4.2.2.2-0.1.el7.noarch

Comment 10 Lucie Leistnerova 2018-03-06 10:38:26 UTC
Created attachment 1404760 [details]
export template confirmation

Comment 11 Alexander Wels 2018-03-14 17:39:14 UTC
*** Bug 1554857 has been marked as a duplicate of this bug. ***

Comment 12 Lucie Leistnerova 2018-03-19 14:26:28 UTC
No html tags in messages and notes. Messages keep new lines, Notes removes them. After discussion with Alexander, I agree that Notes should contain simple text and so no new lines are needed.

verified in ovirt-engine-webadmin-portal-4.2.2.4-0.1.el7.noarch

Comment 13 Sandro Bonazzola 2018-03-29 11:13:54 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 14 Tomas Jelinek 2018-04-18 07:30:16 UTC
*** Bug 1544299 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.