Red Hat Bugzilla – Bug 1540814
upgrade dbscript fails if multiplication overflows
Last modified: 2018-05-15 13:49:44 EDT
Attempting to upgrade when vm_static.mem_size_db contains a value exceeding (2**29-1) fails with the error "integer out of range", leaving the engine down until manual intervention is performed. This was originally reported as a side effect of the testing taken in bug 1496602. The offending query is: /usr/share/ovirt-engine/dbscripts/upgrade/04_01_0640_add_max_memory_size_column.sql > UPDATE vm_static > SET max_memory_size_mb = LEAST(4 * mem_size_mb, 1048576); A simple fix might be: > UPDATE vm_static > SET max_memory_size_mb = LEAST(4 * LEAST(536870911, mem_size_mb), 1048576);
I thought this was fixed some time ago. Which version was used?
(In reply to Yaniv Kaul from comment #2) > I thought this was fixed some time ago. > Which version was used? I don't think this precise issue was fixed. Original report was using 4.1.5, and I see the script unmodified in 4.1.9 and upstream master. I have not tried the full upgrade process to verify the problem, but running this script alone still triggers the error under the conditions described. I do see a related issue fixed upstream in 2016, using a cleaner method than I suggested: https://gerrit.ovirt.org/#/c/51420/ which suggests the following change in 04_01_0640_add_max_memory_size_column.sql, which works in my tests: > UPDATE vm_static > SET max_memory_size_mb = LEAST(4 * mem_size_mb::bigint, 1048576);
(In reply to Yaniv Kaul from comment #2) > I thought this was fixed some time ago. bug 1519811? That's the opposite case. The fix should be trivial
WARN: Bug status (ON_QA) wasn't changed but the folowing should be fixed: [Found non-acked flags: '{'rhevm-4.2-ga': '?'}', ] For more info please contact: rhv-devops@redhat.comINFO: Bug status (ON_QA) wasn't changed but the folowing should be fixed: [Found non-acked flags: '{'rhevm-4.2-ga': '?'}', ] For more info please contact: rhv-devops@redhat.com
ok, update from ovirt-engine-4.2.1-0.2.el7.noarch to ovirt-engine-4.2.2.1-0.1.el7.noarch
INFO: Bug status (VERIFIED) wasn't changed but the folowing should be fixed: [Tag 'ovirt-engine-4.2.2.4' doesn't contain patch 'https://gerrit.ovirt.org/87258'] gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.2.2.4 For more info please contact: rhv-devops@redhat.com
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2018:1488