Moving to sosreport component under RHEL because that is where we expect the code to land. The first step would be to send a patch to upstream sosreport.

Carlos, can you please list all files we'd like to collect for Octavia? You can gain inspiration from other openstack sosreport plugins:
https://github.com/sosreport/sos/tree/master/sos/plugins

Given the fact there is no work done, reviewing PR will take some time and proximity of 7.5.0 date, I dont think we will be able to incorporate the plugin into 7.5.0 errata. So updating flags.

If 7.5.z is required, please raise it.

I can help with the plugin (to some extent), let me know via mail if needed.

profiles = ('openstack', 'openstack_controller')


RPM packages:
openstack-octavia-amphora-agent
openstack-octavia-api
openstack-octavia-common
openstack-octavia-diskimage-create
openstack-octavia-health-manager
openstack-octavia-housekeeping
openstack-octavia-ui
openstack-octavia-worker
puppet-octavia
python-octavia
python-octaviaclient


Log files:
/var/log/containers/httpd/octavia-api/*.log
/var/log/containers/octavia/*.log
/var/log/octavia/*.log


etc files:
/etc/logrotate.d/openstack-octavia
/etc/octavia/*


Puppet files:
/var/lib/octavia
/var/lib/config-data/puppet-generated/octavia/etc/octavia/
/var/lib/config-data/puppet-generated/octavia/etc/my.cnf.d/tripleo.cnf



def check_enabled(self):
        return self.is_installed("openstack-octavia-common")



add_cmd_output:
openstack loadbalancer list
openstack loadbalancer amphora list
openstack loadbalancer healthmonitor list
openstack loadbalancer l7policy list
openstack loadbalancer pool list
openstack loadbalancer quota list




Command requiring argument:

openstack loadbalancer l7rule list <l7policy>
openstack loadbalancer member list <pool>


Retrieve information from each load balancer (similar to https://github.com/sosreport/sos/blob/master/sos/plugins/openstack_nova.py#L90)


for lb_id in $(openstack loadbalancer list -f id);
do
    openstack loadbalancer loadbalancer show $ld_id
done

Created attachment 1400538 [details]
initial version of the plugin

Copy it under

/usr/lib/python2.7/site-packages/sos/plugins/

directory and test it.

Few questions:

(0) I added effect of --all-logs cmdline argument - using it, all files (not only *.log) from the relevant dirs will be collected.

Also worth to know the default limit 10MB is applied here.

Let me know if either of above is a problem.


(1)
> Command requiring argument:
> 
> openstack loadbalancer l7rule list <l7policy>
> openstack loadbalancer member list <pool>

Where to take the argument from? Parsing some output of cmds:

openstack loadbalancer l7policy list
openstack loadbalancer pool list

(or iterate over those two lists and take cmds for each member, like done for "openstack loadbalancer loadbalancer show $ld_id" ?)


(2) I know OSP is often containerized, what implies some changes in configs/logs/cmds. Wont this happen here as well?


(3) Can't be there some password/certificate/secret in data collected we shall obfuscate?



(once we have some stable version of the plugin, I will create PR in upstream)

needinfo for the plugin testing

I am still waiting for a RDO Queens/OSP 13 deployment to test with your octavia sosreport plugin.


(1) I'll do it.

(2) Overcloud is containerized from OSP 13 onward. I based my input in comment #9 based on existing sosreport plugins, which I assume cover configs/logs/cmds on containerized envs. If I missed something, could you please be more detailed? Thank you.

(3) I'll have a look once I get a deployment running and report back.

Created attachment 1413620 [details]
openstack_octavia.py.new

Created attachment 1413631 [details]
openstack_octavia.py.diff

Pavel, 

(1) Completed the missing l7rule and member list commands.

(2) the plugin is collecting the config and log files in a containerized deployment.

(3) ofuscated couple of passwords/key-phrases.

(4) added a verify step to log installed RPMs (rpm -V), although it does only log whether the packages are installed or not and that is consistent with other plugins. Could we log the package NVR even if breaks consistency?


Attaching updated file and diff file.

Thanks, fixed one minor formatting stuff and create upstream PR after review.

devel_ack+ for 7.6

for 7.5.z if needed, please provide business justification and get PMApproved.

GSSApproved for 7.5.z

posted to dist-git

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:3144