Description of problem: Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. create a new dialog with a tag control that has a category, save it 2. edit that dialog and change the category Actual results: New category does not save Expected results: New category should change Additional info: is the second half of https://bugzilla.redhat.com/show_bug.cgi?id=1540713
Please assess the impact of this issue and update the severity accordingly. Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition. If it's something like a tracker bug where it doesn't matter, please set the severity to Low.
https://github.com/ManageIQ/manageiq/pull/16965
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/571572ef184f6098c35d4e6ef490ce649d34333c commit 571572ef184f6098c35d4e6ef490ce649d34333c Author: Drew Bomhof <dbomhof> AuthorDate: Wed Feb 7 13:51:33 2018 -0500 Commit: Drew Bomhof <dbomhof> CommitDate: Fri Feb 9 15:01:25 2018 -0500 Lookup a category_id if a tag control passes it in When editing a tag control for service dialogs, we were always looking up by the name coming in from the dialog. For a new record this sufficed, for an edit it caused edits to fail. This changes the order of lookups to first check the category_id if it comes in, and to fallback to the name if there is no category_id https://bugzilla.redhat.com/show_bug.cgi?id=1542590 app/models/dialog_field_importer.rb | 19 ++++++++++------- spec/models/dialog_field_importer_spec.rb | 35 ++++++++++++++++++++++++++----- 2 files changed, 41 insertions(+), 13 deletions(-)
Waiting on another PR from ui-components to fully fix this BZ. Holding off from moving it to POST due to that.
PR: https://github.com/ManageIQ/ui-components/pull/253
New commit detected on ManageIQ/ui-components/master: https://github.com/ManageIQ/ui-components/commit/8d68195c959da670a513baf5386a57b4aa91ceb3 commit 8d68195c959da670a513baf5386a57b4aa91ceb3 Author: Drew Bomhof <dbomhof> AuthorDate: Mon Feb 12 14:35:08 2018 -0500 Commit: Drew Bomhof <dbomhof> CommitDate: Mon Feb 12 19:46:34 2018 -0500 Set ng-change for tag control options Create a function setupCategoryOptions to be called on ng-change https://bugzilla.redhat.com/show_bug.cgi?id=1542590 src/dialog-editor/components/abstractModal.ts | 1 + .../modalFieldTemplateComponent.ts | 1 + .../modal-field-template/tag-control.html | 1 + .../components/modal-field/field.html | 1 + .../components/modal/modalComponent.spec.ts | 26 ++++++++++++++++++++++ .../components/modal/modalComponent.ts | 17 ++++++++++++++ 6 files changed, 47 insertions(+) create mode 100644 src/dialog-editor/components/modal/modalComponent.spec.ts