Bug 1540713 - Editor won't load after import when tag control category doesn't exist on destination
Summary: Editor won't load after import when tag control category doesn't exist on des...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: drew uhlmann
QA Contact: Shveta
URL:
Whiteboard:
Depends On:
Blocks: 1542606
TreeView+ depends on / blocked
 
Reported: 2018-01-31 20:34 UTC by Shveta
Modified: 2019-02-11 13:59 UTC (History)
8 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1542606 (view as bug list)
Environment:
Last Closed: 2019-02-11 13:59:35 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
dialog (28.31 KB, text/x-vhdl)
2018-01-31 20:34 UTC, Shveta
no flags Details
domain (834.65 KB, application/zip)
2018-01-31 20:34 UTC, Shveta
no flags Details
Tags_2 dialog export for testing (1.73 KB, text/x-vhdl)
2018-02-02 18:55 UTC, Greg McCullough
no flags Details

Description Shveta 2018-01-31 20:34:37 UTC
Created attachment 1389175 [details]
dialog

Description of problem:
This bug is same as https://bugzilla.redhat.com/show_bug.cgi?id=1525091.

Version-Release number of selected component (if applicable):
5.9.0.18.20180125190915_e0d3417

How reproducible:


Steps to Reproduce:
1. Import the dialog and domain attached .
2. Edit the dialog in OPS UI , Internal server error shows.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Shveta 2018-01-31 20:34:57 UTC
Created attachment 1389176 [details]
domain

Comment 4 Greg McCullough 2018-02-02 15:56:36 UTC
DrewB - Please work with DrewU (and Erik if needed) to determine if this is an issue with importing or with the editor.

Comment 5 drew uhlmann 2018-02-02 17:27:12 UTC
Looks like this is due to the category of the dialog field tag controls not existing on the appliance the dialog is being importing to. EC says we should bail in this case. GM, do you have opinions on how to handle this?

Comment 6 Greg McCullough 2018-02-02 18:08:11 UTC
In 5.8 we still imported the dialog but without a selected tag category for that control.  The user would be required to modify it after import.  

The same functionality would be required here.

Comment 7 Greg McCullough 2018-02-02 18:09:12 UTC
I have a 5.8.3 appliance for reference here: https://10.8.199.27

Comment 8 Greg McCullough 2018-02-02 18:55:11 UTC
Created attachment 1390290 [details]
Tags_2 dialog export for testing

Comment 9 drew uhlmann 2018-02-05 15:50:39 UTC
There are two problems: the editor won't load because  https://github.com/ManageIQ/manageiq/blob/master/app/models/dialog_field_serializer.rb#L26 returns nil for non-valid categories, and the editor doesn't correctly save changed, valid categories. The first is solved by https://github.com/ManageIQ/manageiq/pull/16951. The second is an editor issue. 

If I create a new dialog with a tag control that has a category, save it, then edit that dialog and change the category, the new category will not save.

Comment 10 drew uhlmann 2018-02-06 15:53:28 UTC
Marking this as post, bot doesn't seem to have noticed it, will create new BZ and link for the second issue in last comment.

Comment 12 drew uhlmann 2018-02-06 16:20:46 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=1542590 is the bug for the second issue

Comment 13 Shveta 2018-10-12 21:03:29 UTC
Fixed .
verified in 5.10.0.19.20181009184346_1c8bf5d


Note You need to log in before you can comment on or make changes to this bug.