Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1542887

Summary:	Combine openshift_master/vars with defaults
Product:	OpenShift Container Platform	Reporter:	Sunil Choudhary <schoudha>
Component:	Installer	Assignee:	Michael Gugino <mgugino>
Status:	CLOSED ERRATA	QA Contact:	Gaoyun Pei <gpei>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.7.0	CC:	aos-bugs, jokerman, mmccomas
Target Milestone:	---
Target Release:	3.7.z
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-05 09:38:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sunil Choudhary 2018-02-07 09:42:05 UTC

The ansible playbook in /usr/share/ansible/openshift-ansible/roles/openshift_master/vars/main.yml have definitions to modify journal variables.

To prevent modification to journal variables, flag --extra-vars 'journald_vars_to_replace=[]' or extra vars file would be required. This approach could be error prone.

This variable has been moved to defaults in upstream in this commit:
https://github.com/openshift/openshift-ansible/commit/d227dc7233cb7adf34da619da6f6a3bed2eaac18

This bugzilla request is to back-port this to OCP 3.7

Comment 1 Michael Gugino 2018-02-07 18:16:49 UTC

Unfortunately, due to how we perform upgrades on 3.7, we need that vars file to be present.

We could create a new role and use import_role in 3.7 to achieve a similar result.

Comment 2 Michael Gugino 2018-02-07 18:45:13 UTC

Scott proposed a good solution.

PR Created: https://github.com/openshift/openshift-ansible/pull/7054

Comment 4 Gaoyun Pei 2018-02-26 09:13:54 UTC

Verify this bug with openshift-ansible-3.7.31-1.git.0.08008d0.el7.noarch.rpm

1) /etc/systemd/journald.conf would be changed to the default value when no "journald_vars_to_replace" set in ansible inventory file.

[root@qe-gpei-bug777master-etcd-1 ~]# grep -v ^# /etc/systemd/journald.conf

[Journal]
 Storage=persistent
 Compress=True
 SyncIntervalSec=1s
 RateLimitInterval=1s
 RateLimitBurst=10000
 SystemMaxUse=8G
 SystemMaxFileSize=10M
 MaxRetentionSec=1month
 ForwardToSyslog=False
 ForwardToWall=False


2) No changes would be made when setting "journald_vars_to_replace=[]" in ansible inventory file.

[root@qe-gpei-bug666master-etcd-1 ~]# grep -v ^# /etc/systemd/journald.conf

[Journal]


3) /etc/systemd/journald.conf would be changed just as what was setting in journald_vars_to_replace, like journald_vars_to_replace=[{"var":"RateLimitBurst","val":"1000"}, {"var":"SyncIntervalSec","val":"2s"}, {"var":"ForwardToSyslog","val":"no"}, {"var":"MaxLevelSyslog","val":"info"}]

[root@qe-gpei-bug555master-etcd-1 ~]# grep -v ^# /etc/systemd/journald.conf

[Journal]
 SyncIntervalSec=2s
 RateLimitBurst=1000
 ForwardToSyslog=no
 MaxLevelSyslog=info

Comment 8 errata-xmlrpc 2018-04-05 09:38:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0636