Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1544030

Summary: tuned cpu-partitioning profile will configure isolation on all nodes if values are quoted
Product: Red Hat OpenStack Reporter: Andreas Karis <akaris>
Component: documentationAssignee: Sandra McCann <samccann>
Status: CLOSED CURRENTRELEASE QA Contact: Yariv <yrachman>
Severity: high Docs Contact: Sandra McCann <samccann>
Priority: high    
Version: 10.0 (Newton)CC: atelang, jraju, mburns, srevivo
Target Milestone: asyncKeywords: Triaged, ZStream
Target Release: 10.0 (Newton)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1601077 (view as bug list) Environment:
Last Closed: 2018-06-28 15:35:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1570832    

Description Andreas Karis 2018-02-09 22:25:28 UTC 
Description of problem:
tuned cpu-partitioning profile will configure affinity corese if values are quoted

Test in a lab:
~~~
[root@overcloud-compute-0 pcm]# grep -i isol /etc/tuned/cpu-partitioning-variables.conf 
# isolated_cores=2,4-7
# isolated_cores=2-23
isolated_cores=2,4,6,8,10,12,14,16,18,22,24,26,28,30,32,34,36,38,3,5,7,9,11,13,15,17,19,23,25,27,29,31,33,35,37,39
[root@overcloud-compute-0 pcm]# grep -i affini /etc/systemd/system.conf 
#CPUAffinity=1 2
CPUAffinity=0 1 20 21
~~~

~~~
[root@overcloud-compute-0 pcm]# vi /etc/tuned/cpu-partitioning-variables.conf 
[root@overcloud-compute-0 pcm]# grep -i isol /etc/tuned/cpu-partitioning-variables.conf 
# isolated_cores=2,4-7
# isolated_cores=2-23
isolated_cores='2,4,6,8,10,12,14,16,18,22,24,26,28,30,32,34,36,38,3,5,7,9,11,13,15,17,19,23,25,27,29,31,33,35,37,39'
[root@overcloud-compute-0 pcm]# tuned-adm  profile cpu-partitioning
[root@overcloud-compute-0 pcm]# grep -i affini /etc/systemd/system.conf 
#CPUAffinity=1 2
CPUAffinity=0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39
~~~

~~~
[root@overcloud-compute-0 pcm]# vi /etc/tuned/cpu-partitioning-variables.conf 
[root@overcloud-compute-0 pcm]# grep -i isol /etc/tuned/cpu-partitioning-variables.conf 
# isolated_cores=2,4-7
# isolated_cores=2-23
isolated_cores=2,4,6,8,10,12,14,16,18,22,24,26,28,30,32,34,36,38,3,5,7,9,11,13,15,17,19,23,25,27,29,31,33,35,37,39
[root@overcloud-compute-0 pcm]#  tuned-adm  profile cpu-partitioning

[root@overcloud-compute-0 pcm]# 
[root@overcloud-compute-0 pcm]# grep -i affini /etc/systemd/system.conf
#CPUAffinity=1 2
CPUAffinity=0 1 20 21
~~~

Can we make this a bit more fool proof and accept quoted core lists?

Thanks,

Andreas
Comment 3 Andreas Karis 2018-07-13 19:34:51 UTC 
Hi,

The intention of this bug was not to close this within the documentation component. 

It's a bug that tuned cpu-partitioning profile does accept values that are quoted and then misconfigures the core isolation on the entire OS.

Either cpu-partitioning should be able to understand values that are put in quotes, or it should fail. It shouldn't misconfigure the entire OS just because an administrator inserts the core list in single quotes.

- Andreas
Comment 4 Andreas Karis 2018-07-13 19:35:56 UTC 
tuned and cpu-partitioning are standalone components that customers can use without tripleo, so I'd expect the cpu-partitioning tuned profile to catch these kinds of syntax errors and handle them with an error or by being less strict on the requires syntax.