Bug 1601077

+++ This bug was initially created as a clone of Bug #1544030 +++

Description of problem:
tuned cpu-partitioning profile will configure affinity corese if values are quoted

Test in a lab:
~~~
[root@overcloud-compute-0 pcm]# grep -i isol /etc/tuned/cpu-partitioning-variables.conf 
# isolated_cores=2,4-7
# isolated_cores=2-23
isolated_cores=2,4,6,8,10,12,14,16,18,22,24,26,28,30,32,34,36,38,3,5,7,9,11,13,15,17,19,23,25,27,29,31,33,35,37,39
[root@overcloud-compute-0 pcm]# grep -i affini /etc/systemd/system.conf 
#CPUAffinity=1 2
CPUAffinity=0 1 20 21
~~~

~~~
[root@overcloud-compute-0 pcm]# vi /etc/tuned/cpu-partitioning-variables.conf 
[root@overcloud-compute-0 pcm]# grep -i isol /etc/tuned/cpu-partitioning-variables.conf 
# isolated_cores=2,4-7
# isolated_cores=2-23
isolated_cores='2,4,6,8,10,12,14,16,18,22,24,26,28,30,32,34,36,38,3,5,7,9,11,13,15,17,19,23,25,27,29,31,33,35,37,39'
[root@overcloud-compute-0 pcm]# tuned-adm  profile cpu-partitioning
[root@overcloud-compute-0 pcm]# grep -i affini /etc/systemd/system.conf 
#CPUAffinity=1 2
CPUAffinity=0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39
~~~

~~~
[root@overcloud-compute-0 pcm]# vi /etc/tuned/cpu-partitioning-variables.conf 
[root@overcloud-compute-0 pcm]# grep -i isol /etc/tuned/cpu-partitioning-variables.conf 
# isolated_cores=2,4-7
# isolated_cores=2-23
isolated_cores=2,4,6,8,10,12,14,16,18,22,24,26,28,30,32,34,36,38,3,5,7,9,11,13,15,17,19,23,25,27,29,31,33,35,37,39
[root@overcloud-compute-0 pcm]#  tuned-adm  profile cpu-partitioning

[root@overcloud-compute-0 pcm]# 
[root@overcloud-compute-0 pcm]# grep -i affini /etc/systemd/system.conf
#CPUAffinity=1 2
CPUAffinity=0 1 20 21
~~~

Can we make this a bit more fool proof and accept quoted core lists?

Thanks,

Andreas

--- Additional comment from atelang on 2018-04-04 22:58:02 EDT ---

From our BZ triage, this seems like we need doc that says " Do not edit/change the isolated_cores or other values directly modified by TripleO in the file  /etc/tuned/cpu-partitioning-variables.conf"

(...)

Hi,

The intention of this bug was not to close this within the documentation component. 

It's a bug that tuned cpu-partitioning profile does accept values that are quoted and then misconfigures the core isolation on the entire OS.

Either cpu-partitioning should be able to understand values that are put in quotes, or it should fail. It shouldn't misconfigure the entire OS just because an administrator inserts the core list in single quotes.

- Andreas

--- Additional comment from Andreas Karis on 2018-07-13 15:35:56 EDT ---

tuned and cpu-partitioning are standalone components that customers can use without tripleo, so I'd expect the cpu-partitioning tuned profile to catch these kinds of syntax errors and handle them with an error or by being less strict on the requires syntax.