Bug 1549486
| Summary: | [RFE] update landing and login pages to to be compatible with Patternfly 4 | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Greg Sheremeta <gshereme> |
| Component: | Frontend.WebAdmin | Assignee: | Sharon Gratch <sgratch> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Ivana Saranova <isaranov> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.2.1 | CC: | bugs, dfodor, isaranov, lwright, sdickers, sgratch |
| Target Milestone: | ovirt-4.4.0 | Keywords: | FutureFeature |
| Target Release: | --- | Flags: | rule-engine:
ovirt-4.4?
rule-engine: planning_ack? pm-rhel: devel_ack+ lleistne: testing_ack+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt-engine 4.4.0 alpha 551beb5b | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-20 19:59:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1696169 | ||
|
Description
Greg Sheremeta
2018-02-27 09:04:23 UTC
https://gerrit.ovirt.org/#/c/104354/ resolves this issue. The landing page and login page for oVirt are integrated by appropriate PF4 styles. I tried my best comparing the admin portal and VM portal login page to the patternfly4 example one and found some issues. However, if you feel like they are not issues (probably the ones noted in the 1, might be by design), please let me know.
1) The logo seems to be a bit on the small side. The description text under logo is not centre aligned. Title ('Log in to your account') is also not centre aligned.
2) The login screen is getting all over the place when you make the browser window narrower. Resolutions of the inner sizes of broswer windows are approx. 1900x950px, 950x700px, 1040x1800px (pics in the attachments)
Tested in:
ovirt-engine-4.4.0-0.17.master.el7.noarch
ovirt-web-ui-1.6.0-2.el7ev.noarch
ovirt-engine-webadmin-portal-4.4.0-0.17.master.el7.noarch
firefox-71.0-15.fc31.x86_64
BZ1795232 extends the PF4 work on error and non-webadmin pages. Sharon, Ivana - Perhaps that BZ and this one should be tested together? Either way Laura should take a look to make sure they line up with PF designs and her mockups. The text alignment looks fine to me, one of the more overarching text alignment changes in PatternFly 4 was moving things to be left aligned and having fewer instances of using center aligned text. The logo size looks fine to me as well. Okay, so I have found some more potential issues. 1) The big background fedora does not have stable background - sometimes the fedora is inside the lighter grey column, sometimes it goes into the darker grey column. The landing page has the same issue being divided between the two dark/light grey background columns and then makes a weird triangle at the top if the window is resized. 2) The dividers between document topics seem to be too small and there are no spaces above or below which makes it a bit crowded in my opinion. 3) If you resize the window to almost phone/tablet resolution, the user menu at top right corner disappears completely and is nowhere to be found. 4) Error/warning/info messages appear in a bit weird place next to the version of the engine. 5) Next Auth button is positioned very closely to the login button and has different design than the login button. 6) If you just go to the Switch User, but do not do anything and just return back to the landing page by clicking on the logo, the user is not logged anymore and there is the Next Auth in every login page unless you open the login page in new session. Tested in: ovirt-engine-4.4.0-0.25.master.el8ev.noarch ovirt-engine-webadmin-portal-4.4.0-0.25.master.el8ev.noarch rhvm-branding-rhv-4.4.1-2.el8ev.noarch firefox-73.0.1-1.fc31.x86_64 @Ivana - At least a few of those issues have been resolved in the followup BZ1795232. The Switch User / Next Auth button issues are known and will be followed up on separately. See the last few comment on https://gerrit.ovirt.org/#/c/106579/. Sorry for the confusion! Ivana, please verify this bug for both Chrome and Firefox and with ESR versions as well. Yes, I agree. I checked the message overflowing behaviour in newer version of ovirt-engine and it seems to be fixed, so there's no need to open separate bug for it anymore. Therefore, I'm moving to verified. Verified in: ovirt-engine-4.4.0-0.0.master.20200317103500.git3e2b0274306.el8.noarch rhvm-4.4.0-0.29.master.el8ev.noarch rhvm-branding-rhv-4.4.2-1.el8ev.noarch firefox-74.0-3.fc31.x86_64 This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020. Since the problem described in this bug report should be resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |