Bug 1553218 - Start VM with inactive attached disk fails with NPE
Summary: Start VM with inactive attached disk fails with NPE
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.2.2
Hardware: x86_64
OS: Unspecified
medium
high
Target Milestone: ovirt-4.2.2
: 4.2.2.4
Assignee: Sharon Gratch
QA Contact: Elad
URL:
Whiteboard:
: 1553947 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-08 14:19 UTC by Elad
Modified: 2018-04-18 12:25 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine-4.2.2.4
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2018-04-18 12:25:21 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: blocker+


Attachments (Terms of Use)
logs (18.82 MB, application/x-gzip)
2018-03-08 14:19 UTC, Elad
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 88581 0 master MERGED core: fix npe raised when running a vm with a de-activated disk 2018-03-11 08:26:10 UTC
oVirt gerrit 88698 0 master ABANDONED core: Filter plugged disks when running a VM 2018-03-08 16:40:15 UTC
oVirt gerrit 88764 0 ovirt-engine-4.2 MERGED core: fix npe raised when running a vm with a de-activated disk 2018-03-12 12:22:31 UTC
oVirt gerrit 88766 0 master MERGED core: cleanup in writing disks to engine xml 2018-03-13 15:52:48 UTC
oVirt gerrit 88935 0 ovirt-engine-4.2 MERGED core: cleanup in writing disks to engine xml 2018-03-14 08:59:49 UTC

Description Elad 2018-03-08 14:19:50 UTC
Created attachment 1405872 [details]
logs

Description of problem:
Start to VM that has an inactive disk fails with NullPointerException.

Version-Release number of selected component (if applicable):
rhvm-4.2.2.2-0.1.el7.noarch
vdsm-4.20.20-1.el7ev.x86_64
libvirt-3.9.0-13.el7.x86_64

How reproducible:
Always, on all storage types

Steps to Reproduce:
1. Create a VM and attach a disk as inactive
2. Start the VM


Actual results:
2018-03-08 09:36:47,597+02 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.CreateBrokerVDSCommand] (default task-27) [vms_syncAction_fbc662bd-28c2-4c26] Command 'CreateBrokerVDSCommand(HostName = host_mixed_3, CreateVDSCommandParameters:{hostId='02998d6c-afc5-4813-8929-5fc055829ba7', vmId='9bdf6eac-83e3-44bc-86d4-3e2c6bb46080', vm='VM [vm_TestCase6231_0809354184]'})' execution failed: null
2018-03-08 09:36:47,597+02 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.CreateBrokerVDSCommand] (default task-27) [vms_syncAction_fbc662bd-28c2-4c26] FINISH, CreateBrokerVDSCommand, log id: 7a39f00c
2018-03-08 09:36:47,597+02 ERROR [org.ovirt.engine.core.vdsbroker.CreateVDSCommand] (default task-27) [vms_syncAction_fbc662bd-28c2-4c26] Failed to create VM: java.lang.NullPointerException
        at java.util.HashMap.merge(HashMap.java:1225) [rt.jar:1.8.0_161]
        at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320) [rt.jar:1.8.0_161]
        at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169) [rt.jar:1.8.0_161]


Expected results:
Start VM should succeed

Additional info:
logs

Comment 1 Red Hat Bugzilla Rules Engine 2018-03-08 15:24:45 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 2 Allon Mureinik 2018-03-08 16:44:30 UTC
Sharon - your fix for bug 1543833 also covers this issue.
The scenarios are slightly different, although the underlying issue is the same. I'm moving this BZ to you too, and leaving to your discretion whether to reference them both in the same patch or just close as a duplicate.

Comment 3 Sharon Gratch 2018-03-09 11:34:33 UTC
(In reply to Allon Mureinik from comment #2)
> Sharon - your fix for bug 1543833 also covers this issue.
> The scenarios are slightly different, although the underlying issue is the
> same. I'm moving this BZ to you too, and leaving to your discretion whether
> to reference them both in the same patch or just close as a duplicate.

Since bug 1543833 deals with a different issue then I prefer to reference both to the same patch and not duplicated bugs.

Comment 4 Michal Skrivanek 2018-03-10 06:25:56 UTC
*** Bug 1553947 has been marked as a duplicate of this bug. ***

Comment 5 Elad 2018-04-12 13:43:50 UTC
Start VM starts normally with an inactive disk attached.

Used:
rhvm-4.2.2.6-0.1.el7.noarch
vdsm-4.20.23-1.el7ev.x86_64

Comment 6 Sandro Bonazzola 2018-04-18 12:25:21 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.