Bug 1557435 - Enable lookup-optimize by default
Summary: Enable lookup-optimize by default
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
: 1287004 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-16 15:04 UTC by Nithya Balachandran
Modified: 2018-10-08 04:42 UTC (History)
2 users (show)

Fixed In Version: glusterfs-v4.1.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-20 18:02:26 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Nithya Balachandran 2018-03-16 15:04:32 UTC
Description of problem:

Enable lookup-optimize by default so it will be exercised by the regression tests.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2018-03-16 15:27:09 UTC
REVIEW: https://review.gluster.org/19731 (cluster/dht: enable lookup-optimize by default) posted (#1) for review on master by N Balachandran

Comment 2 Worker Ant 2018-03-28 18:26:53 UTC
REVIEW: https://review.gluster.org/19731 (cluster/dht: enable lookup-optimize by default) posted (#2) for review on master by N Balachandran

Comment 3 Worker Ant 2018-03-29 14:53:06 UTC
REVIEW: https://review.gluster.org/19797 (cluster/dht: Update layout in inode only on success) posted (#1) for review on master by N Balachandran

Comment 4 Worker Ant 2018-04-02 05:22:07 UTC
COMMIT: https://review.gluster.org/19797 committed in master by "Raghavendra G" <rgowdapp> with a commit message- cluster/dht: Update layout in inode only on success

With lookup-optimize enabled, gf_defrag_settle_hash in rebalance
sometimes flips the on-disk layout on volume root post the
migration of all files in the directory.

This is sometimes seen when attempting to fix the layout of a
directory multiple times before calling gf_defrag_settle_hash.
dht_fix_layout_of_directory generates a new layout in memory but
updates it in the inode ctx before it is set on disk. The layout
may be different the second time around due to
dht_selfheal_layout_maximize_overlap. If the layout is then not
written to the disk, the inode now contains the wrong layout.
gf_defrag_settle_hash does not check the correctness of the layout
in the inode before updating the commit-hash and writing it to the
disk thus changing the layout of the directory.

Change-Id: Ie1407d92982518f2a0c40ec70ad370b34a87b4d4
updates: bz#1557435
Signed-off-by: N Balachandran <nbalacha>

Comment 5 Worker Ant 2018-04-04 03:04:02 UTC
COMMIT: https://review.gluster.org/19731 committed in master by "Raghavendra G" <rgowdapp> with a commit message- cluster/dht: enable lookup-optimize by default

Lookup-optimize has been shown to improve create
performance. The code has been in the project for several
years and is considered stable.

Enabling this by default in order to test this in the
upstream regression runs.

Change-Id: Iab792979ee34f0af4713931e0b5b399c23f65313
updates: bz#1557435
BUG: 1557435
Signed-off-by: N Balachandran <nbalacha>

Comment 6 Shyamsundar 2018-06-20 18:02:26 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v4.1.0, please open a new bug report.

glusterfs-v4.1.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-June/000102.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 7 Nithya Balachandran 2018-10-08 04:42:02 UTC
*** Bug 1287004 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.