Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1558722

Summary: [Docs] set "osd_scenario" to "collocated" or "non-collocated" when converting the parameters from puppet to ceph-ansible
Product: Red Hat OpenStack Reporter: Marius Cornea <mcornea>
Component: documentationAssignee: ndeevy <ndeevy>
Status: CLOSED CURRENTRELEASE QA Contact: RHOS Documentation Team <rhos-docs>
Severity: high Docs Contact:
Priority: high    
Version: 13.0 (Queens)CC: cminkema, dbecker, gfidente, johfulto, jomurphy, lmarsh, mburns, mcornea, morazi, ndeevy, rhel-osp-director-maint, srevivo
Target Milestone: ---Keywords: Documentation
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-24 08:49:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
inventory.yaml none

Description Marius Cornea 2018-03-20 21:32:15 UTC 
Created attachment 1410817 [details]
inventory.yaml

Description of problem:
FFU: ceph upgrade fails with "msg": "please choose an osd scenario"

It appears that the inventory file used by ceph-ansible doesn't contain the osd_scenario file anymore and the task in https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-osd/tasks/check_mandatory_vars.yml#L23-L29 fails.

Version-Release number of selected component (if applicable):
ceph-ansible-3.1.0-0.1.beta3.el7.noarch
openstack-tripleo-heat-templates-8.0.0-0.20180304031146.6cd4184.el7ost.noarch
openstack-tripleo-common-8.5.1-0.20180304032202.e8d9da9.el7ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Deploy OSP10 with 3 controllers + 2 computes + 3 ceph osd nodes
2. Run through the FFU upgrade
3. Run the ceph upgrade step

Actual results:
switch-from-non-containerized-to-containerized-ceph-daemons.yml playbook fails with:

2018-03-20 17:12:51,606 p=30979 u=mistral |  fatal: [192.168.24.11]: FAILED! => {
    "changed": false, 
    "msg": "please choose an osd scenario"
}


Expected results:
upgrade completes fine

Additional info:
Attaching the inventory file used when running the ceph-ansible playbook.
Comment 2 Giulio Fidente 2018-03-21 12:10:33 UTC 
Looks like a DUP of BZ #1502841

Marius, any chance you can test this with beta4?
Comment 4 John Fulton 2018-03-21 12:41:09 UTC 
Marius, 

No need to test with beta4 as beta3 (which you used to run into this issue) contains the change from BZ #1502841 as per the fixed-in. 

1502841 is not exactly a duplicate of this bug, it's more of an opposite. After looking into this more, I think you're hitting the new expected behaviour which was requested in 1502841.

If you look at 1502841, you might question; why would we want the deployment to fail if osd_scenario was unset? The reason is described in the bug. In short, without blocking on this check it's possible to get a successful deployment with 0 OSDs. So there's a reason you can't rely on osd_scenario having a default in ceph-ansible any more (sorry I didn't realize this when we were debugging it yesterday).

As the user must make changes between puppet-ceph and ceph-ansible to move to the new platform, I think this should be included in that list of changes. 

I will keep the needinfo on you so we can get your input next. 

  John
Comment 5 Marius Cornea 2018-03-21 22:08:11 UTC 
Quick update: after specifically setting the 'osd_scenario: collocated' parameter when converting the parameters from puppet to ceph-ansible the playbooks completed fine so I think we can go with documenting that the user is required to set osd_scenario when creating the ceph-ansible parameters.
Comment 10 ndeevy 2019-06-24 08:49:13 UTC 
Updated and merged for OSP13-queens: 

https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/13/html-single/fast_forward_upgrades/index#preparing_for_ceph_storage_or_hci_node_upgrades