Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1564082

Summary: On saveconfig dump control string max_data_area_mb
Product: Red Hat Enterprise Linux 7 Reporter: Prasanna Kumar Kalever <prasanna.kalever>
Component: python-rtslibAssignee: Maurizio Lombardi <mlombard>
Status: CLOSED ERRATA QA Contact: Martin Hoyer <mhoyer>
Severity: high Docs Contact:
Priority: urgent    
Version: 7.5CC: cww, mchristi, mhoyer, pkarampu, rcyriac, rhandlin, toneata
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Previously, the "targetcli saveconfig" command did not save the max_data_area_mb control string. As a consequence, the property was lost when restarting the target service or rebooting the node. With this update, the property is saved and restored correctly.
Story Points: ---
Clone Of:
: 1565063 1566106 (view as bug list) Environment:
Last Closed: 2018-10-30 07:44:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1535780, 1554642, 1565063, 1566106    

Description Prasanna Kumar Kalever 2018-04-05 10:28:44 UTC
Description of problem:

saveconfig: dump control string max_data_area_mb

Problem:
-------
$ targetcli /backstores/user:glfs create blockX1 1073741824 test.124.227/block-store/e59309bb-d591-4121-a891-e98ff3416446,max_data_area_mb=32

$ targetcli / saveconfig

$ cat /etc/target/saveconfig.json
{
  "storage_objects": [
    {
      "alua_tpgs": [],
      "attributes": {
        ...
      },
      "config": "glfs/test.124.227/block-store/e59309bb-d591-4121-a891-e98ff3416446",
      "hw_max_sectors": 128,
      "name": "blockX1",
      "plugin": "user",
      "size": 1073741824,
      "wwn": "3aa072d6-a007-45a3-8eac-e85b53655515"
    }
  ],
  "targets": []
}

Note max_data_area_mb is not dumped into the configfile and hence on restart oftarget service or node reboot this storageObject property is lost.

Fix:
---
make sure to append max_data_area_mb to config param, like:
$ cat /etc/target/saveconfig.json
{
  ...
  "config": "glfs/test.124.227/block-store/e59309bb-d591-4121-a891-e98ff3416446,max_data_area_mb=32",
  ...
}

So that on restore and reboot we don't lose the property.

Comment 2 Prasanna Kumar Kalever 2018-04-05 10:29:24 UTC
Patch posted Upstream:
https://github.com/open-iscsi/rtslib-fb/pull/128

Comment 3 Prasanna Kumar Kalever 2018-04-06 08:29:01 UTC
(In reply to Prasanna Kumar Kalever from comment #2)
> Patch posted Upstream:
> https://github.com/open-iscsi/rtslib-fb/pull/128

In addition to above PR we also need:
https://github.com/open-iscsi/targetcli-fb/pull/109

Comment 8 Martin Hoyer 2018-07-10 07:58:13 UTC
Tested with: 
 - kernel-3.10.0-915.el7
 - targetcli-2.1.fb46-6.el7
 - python-configshell-1.1.fb23-4.el7
 - python-rtslib-2.1.fb63-12.el7
The issue is no longer reproducible; No regression found.

Comment 10 errata-xmlrpc 2018-10-30 07:44:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:3019