Created attachment 1419771 [details] screenshots Description of problem: [UI] - Reverse the title and the entity on the NIC panel - MAC, Statistics and for the new vNIC design. For some reason it was designed that the title is shown under the entity it self on the host NIC panel, but it's wrong. The MAC and statistics titles coming under the entity it self. The same should be done for the new design(by amusil) for the VM's vNIC panel - Network name, IPv4/6 and MAC Version-Release number of selected component (if applicable): 4.2.2.6-0.1.el7 How reproducible: 100% Ales, will it be possible to keep bold text of the NIC name aligned to the bold entity text(MAC address and statistics)? Something that Greg for the UI team has done for the current design and i would like to keep this way please. If it's possible to keep the bold text as it is and just move the title on top of the bold entity?
In the attachment are both versions (current and reversed) for the VM nic. We just have to decide which one to use.
Created attachment 1419838 [details] VM nic redesigned
(In reply to Ales Musil from comment #1) > In the attachment are both versions (current and reversed) for the VM nic. > We just have to decide which one to use. Reversed look good to me)
I actually prefer it when the title is smaller and non-bold. I do not care if it is above and below. I'd like a UX expert to judge.
Created attachment 1420328 [details] layout for VM nic Apart from the titles, I also made simpler the details part: Aggregated all the small part to 1 window.
Thank you Eldan, Looks very good to me, ALes what you think?
Created attachment 1421360 [details] vm_nic Here is the result.
(In reply to Ales Musil from comment #7) > Created attachment 1421360 [details] > vm_nic > > Here is the result. Hi Ales, looks great, i have 3 comments: 1) We decided to bold the text of the title and not the value, it make more sense 2) Please align the (Mbps) in the statistics sub tab as Eldan did on attachment in comment 5 , in your screenshots id doesn't aligned. The same should be done for the host NIC panel as well. 3) Note that except re-designing the VM's vNIC, the reverse of the title and value should be done on the host NIC panel as well. Please send me the screenshot after fixing the comments, Thanks,
(In reply to Michael Burman from comment #8) > (In reply to Ales Musil from comment #7) > > Created attachment 1421360 [details] > > vm_nic > > > > Here is the result. > > Hi Ales, looks great, i have 3 comments: > 1) We decided to bold the text of the title and not the value, it make more > sense I don't know who has decided this; I very much prefer to keep the value as bold, and title in a thin font. The title is constant and boring and should be kept quiet. > 2) Please align the (Mbps) in the statistics sub tab as Eldan did on > attachment in comment 5 , in your screenshots id doesn't aligned. The same > should be done for the host NIC panel as well. +1, please do it in a separate patch. > 3) Note that except re-designing the VM's vNIC, the reverse of the title and > value should be done on the host NIC panel as well. +1
(In reply to Dan Kenigsberg from comment #9) > (In reply to Michael Burman from comment #8) > > (In reply to Ales Musil from comment #7) > > > Created attachment 1421360 [details] > > > vm_nic > > > > > > Here is the result. > > > > Hi Ales, looks great, i have 3 comments: > > 1) We decided to bold the text of the title and not the value, it make more > > sense > > I don't know who has decided this; I very much prefer to keep the value as > bold, and title in a thin font. The title is constant and boring and should > be kept quiet. Eldan, Me and Meni decided this. The title should be bold, because you look for the title and only then looking on it's value. After the reverse, if the value will remain bold it will break the look of the host NIC panel as well. > > > 2) Please align the (Mbps) in the statistics sub tab as Eldan did on > > attachment in comment 5 , in your screenshots id doesn't aligned. The same > > should be done for the host NIC panel as well. > > +1, please do it in a separate patch. > > > 3) Note that except re-designing the VM's vNIC, the reverse of the title and > > value should be done on the host NIC panel as well. > > +1
*** Bug 1563651 has been marked as a duplicate of this bug. ***
> > I don't know who has decided this; I very much prefer to keep the value as > > bold, and title in a thin font. The title is constant and boring and should > > be kept quiet. > Eldan, Me and Meni decided this. The title should be bold, because you look > for the title and only then looking on it's value. After the reverse, if the > value will remain bold it will break the look of the host NIC panel as well. Ok, I am not going to fight against Eldan regarding UX (even though he's still wrong). Let the title be bold.
Created attachment 1425865 [details] Redesign after notes Here is redesign after fixing the notes.
Verified on - 4.2.4-0.1.el7
Alignment of the (mbps) wasn't fixed here, i will report new bug for this.
This bugzilla is included in oVirt 4.2.4 release, published on June 26th 2018. Since the problem described in this bug report should be resolved in oVirt 4.2.4 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.