Description of problem:
Cannot put special characters in proxy password in Advanced Config
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Have a password with a special character like ? in it
2. Save and try to add provider
This shows up when trying to validate:
"Credential validation was not successful: Unexpected response returned from system: 407 "Proxy Authentication Required"
Provider added successfully
Note, while testing this fix, we found that we ran into the similar/duplicate bug 1559019 and bug 1552114. Those bugs caused our http proxy settings for a "new" (unsaved) provider to be ignored, leading to a 407 "Proxy Authentication Required" error. Thankfully, David found the above bugs and their fixes and we were able to verify they worked in combination with the changes below.
Therefore, we needed the hotfix for the above bugs in order to test:
1) Jason's original PR on the aws-sdk-ruby gem: https://github.com/aws/aws-sdk-ruby/pull/1760. This will hopefully be merged and released and be the eventual longterm fix.
2) Until that gem is fixed, released and we can update to it, we'll patching the method via the PR from Nick:
Verified in 126.96.36.199. Tried to add ec2 provider through squid proxy where password contained "?" and it was successful.