Bug 1568996 - ValueError: plural forms expression could be dangerous
Summary: ValueError: plural forms expression could be dangerous
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: initial-setup
Version: 38
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Martin Kolman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-04-18 13:34 UTC by Nerijus Baliūnas
Modified: 2024-09-05 04:25 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-05-07 16:52:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch (656 bytes, patch)
2019-05-02 19:58 UTC, Nerijus Baliūnas
no flags Details | Diff

Description Nerijus Baliūnas 2018-04-18 13:34:28 UTC
Please see bug 1334960 and bug 1364114.

There is a typo in initial-setup/po/lt.po (Lithuanian translation):

"Plural-Forms: nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 : n%10>=2 && (n%100<10 or n%100>=20) 

should be ("or" is considered to be an identifier by gettext):

"Plural-Forms: nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 : n%10>=2 && (n%100<10 || n%100>=20)

Please fix Plural-Forms headers (s/or/||/).

Comment 1 Ben Cotton 2019-05-02 19:19:23 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 2 Nerijus Baliūnas 2019-05-02 19:58:58 UTC
Created attachment 1561952 [details]
patch

Patch attached.

Comment 3 Ben Cotton 2019-05-02 21:54:53 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Ben Cotton 2020-04-30 22:09:04 UTC
This message is a reminder that Fedora 30 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 30 on 2020-05-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '30'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 30 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora Program Management 2021-04-29 15:54:03 UTC
This message is a reminder that Fedora 32 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 32 on 2021-05-25.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '32'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 32 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Martin Kolman 2021-09-17 12:18:19 UTC
Looking at the Fedora translation service instance, there does not appear to be a Lithuanian translation for Initial Setup at the moment:

https://translate.fedoraproject.org/projects/initial-setup/master/

I wonder if it perhaps somehow got lost when Fedora migrated translations from Zanata to Weblate in 2020 ?

Comment 7 Ben Cotton 2022-05-12 16:15:03 UTC
This message is a reminder that Fedora Linux 34 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '34'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 34 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 8 Nerijus Baliūnas 2022-05-12 17:46:00 UTC
Still not fixed in initial-setup-0.3.94-2.fc36.x86_64.rpm.

Comment 9 Nerijus Baliūnas 2022-05-12 17:54:01 UTC
(In reply to Martin Kolman from comment #6)
> Looking at the Fedora translation service instance, there does not appear to
> be a Lithuanian translation for Initial Setup at the moment:
> 
> https://translate.fedoraproject.org/projects/initial-setup/master/
> 
> I wonder if it perhaps somehow got lost when Fedora migrated translations
> from Zanata to Weblate in 2020 ?

I checked lt.po in initial-setup-0.3.94-2.fc36.src.rpm - it is empty with no translations except that bogus line with "or".
initial-setup-0.3.94.tar.gz date is October 2021, so I am not sure why it contains lt.po if it does not exist in Weblate.

In spec file changelog I see that you generated 0.3.94-1 version:
* Tue Oct 12 2021 Martin Kolman <mkolman> - 0.3.94-1

As there is no info in initial-setup.spec how the tarball was generated, probably only you can fix this.
A similar problem is in https://bugzilla.redhat.com/show_bug.cgi?id=1569004

Comment 10 Ben Cotton 2023-04-25 16:38:34 UTC
This message is a reminder that Fedora Linux 36 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 36 on 2023-05-16.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '36'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 36 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 11 Nerijus Baliūnas 2023-04-25 17:04:00 UTC
Still not fixed in initial-setup-0.3.97-1.fc38.x86_64.rpm.

Comment 12 Jiri Konecny 2023-05-16 13:56:32 UTC
Hello this translation shouldn't be part of the project because it's not between localized languages here: https://translate.fedoraproject.org/projects/initial-setup/master/ not sure why.

Comment 13 Nerijus Baliūnas 2023-05-16 14:26:22 UTC
initial-setup.spec:

# This is a Red Hat maintained package which is specific to
# our distribution.
#
# The source is thus available only from within this SRPM
# or via direct git checkout:
# git clone https://github.com/rhinstaller/initial-setup
Source0: %{name}-%{version}.tar.gz

As it is unknown how the initial-setup-0.3.97.tar.gz was generated, only you can fix this.

Comment 14 Nerijus Baliūnas 2023-05-16 14:42:29 UTC
I did "git clone https://github.com/rhinstaller/initial-setup; cd initial_setup; make archive" and generated initial-setup-0.3.97.tar.gz does not have lt.po (it has 55 *.po files, while initial-setup-0.3.97-1.fc38.src.rpm has 118). The additional files are added from somewhere else.

Comment 15 Aoife Moloney 2024-05-07 15:41:19 UTC
This message is a reminder that Fedora Linux 38 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 38 on 2024-05-21.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '38'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 38 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 16 Nerijus Baliūnas 2024-05-07 16:52:54 UTC
It is finally fixed in initial-setup-0.3.100-3.fc40.x86_64.rpm.

Comment 17 Red Hat Bugzilla 2024-09-05 04:25:02 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days


Note You need to log in before you can comment on or make changes to this bug.