Bug 1572551 - The error msg is not clear when blkdeviotune a cdrom without media for a running guest
Summary: The error msg is not clear when blkdeviotune a cdrom without media for a runn...
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: libvirt
Version: 8.0
Hardware: x86_64
OS: Linux
Target Milestone: rc
: ---
Assignee: Virtualization Maintenance
QA Contact: Han Han
Depends On:
TreeView+ depends on / blocked
Reported: 2018-04-27 10:08 UTC by Xiaoyan Wu
Modified: 2020-02-18 14:10 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-02-18 14:10:37 UTC
Type: Bug
Target Upstream Version:

Attachments (Terms of Use)
libvirtd.log (3.98 MB, text/plain)
2018-04-27 10:08 UTC, Xiaoyan Wu
no flags Details

Description Xiaoyan Wu 2018-04-27 10:08:59 UTC
Created attachment 1427604 [details]

Description of problem:
The error msg is not clear when blkdeviotune a cdrom without media for a running guest

Version-Release number of selected component (if applicable):

 How reproducible:

 Steps to Reproduce:
 1.add a cdrom without media to guest xml:
   <disk type='file' device='cdrom'>
      <driver name='qemu' type='raw'/>
    <target dev='hda' bus='ide'/>
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>

 2.#virsh start 02test

 3.# virsh blkdeviotune 02test hda
error: Unable to get block I/O throttle parameters
error: internal error: block_io_throttle inserted entry was not in expected format

 Actual results:
1. In step3,executed # virsh blkdeviotune 02test hda ,report unclear error.
2. The error behaves differently with a shutoff scenario, refer to addtional info.

 Expected results:
The error should show its specific reason(empty disk or sth), to distinguish with other potential issues such as bz872582.

 Additional info: 
1. when guest shutoff, it gives an output:
# virsh shutdown 02test
# virsh blkdeviotune 02test hda
total_bytes_sec: 0
read_bytes_sec : 0
write_bytes_sec: 0
total_iops_sec : 0
read_iops_sec  : 0
write_iops_sec : 0
total_bytes_sec_max: 0
read_bytes_sec_max: 0
write_bytes_sec_max: 0
total_iops_sec_max: 0
read_iops_sec_max: 0
write_iops_sec_max: 0
size_iops_sec  : 0
group_name     : 
total_bytes_sec_max_length: 0
read_bytes_sec_max_length: 0
write_bytes_sec_max_length: 0
total_iops_sec_max_length: 0
read_iops_sec_max_length: 0
write_iops_sec_max_length: 0

2. when guest running with a media in cdrom, it works well.

Comment 2 Peter Krempa 2018-04-27 10:45:15 UTC
The IO tuning stuff will be completely refactored when doing blockdev implementation, so that may actually fix it.

Comment 3 Martin Kletzander 2018-04-27 13:27:06 UTC
(In reply to Peter Krempa from comment #2)
Any possibility that it would fix Bug 1377648, Bug 1344897 and Bug 1344897 as well?  Feel free to take all those BZ if you think it might.  You'll also know how it might be tied together in the code after the refactor.

Comment 5 Jaroslav Suchanek 2020-02-18 14:10:37 UTC
This bug was closed deferred as a result of bug triage.

Please reopen if you disagree and provide justification why this bug should
get enough priority. Most important would be information about impact on
customer or layered product. Please indicate requested target release.

Note You need to log in before you can comment on or make changes to this bug.