+++ This bug was initially created as a clone of Bug #1577162 +++
+++ This bug was initially created as a clone of Bug #1575716 +++
Description of problem:
glfs_upcall_register(), glfs_upcall_unregister(), and glfs_h_poll_upcall did not follow the guidelines, broke build on FreeBSD 11, potential obscure bugs on Linux.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
--- Additional comment from Worker Ant on 2018-05-07 14:58:47 EDT ---
REVIEW: https://review.gluster.org/19974 (gfapi: various broken symbol versions) posted (#1) for review on master by Kaleb KEITHLEY
--- Additional comment from Worker Ant on 2018-05-10 17:43:41 EDT ---
COMMIT: https://review.gluster.org/19974 committed in master by "Kaleb KEITHLEY" <firstname.lastname@example.org> with a commit message- gfapi: various broken symbol versions
lots of breakage in symbol versions:
symbols added in 4.1 incorrectly, and
symbols added in 4.1 but labeled 4.0.0, and
symbols added in 3.13 incorrectly
Not noticed until someone tried to build 3.13.2 on FreeBSD 11.1,
despite the fact that we build on FreeBSD 10.3 IIRC, somehow the
3.13 errors aren't a build error there.
Note: in rereading the Ulrich Drepper write-up I noticed that when
a symbol version is changed, you are supposed to leave the old
symbol in its original section in addition to adding it to its new
section. Adding back those symbols to their original sections.
Reported-by: Roman Serbski <email@example.com>
Signed-off-by: Kaleb S. KEITHLEY <firstname.lastname@example.org>
REVIEW: https://review.gluster.org/20008 (gfapi: various broken symbol versions) posted (#1) for review on release-4.0 by Kaleb KEITHLEY
REVIEW: https://review.gluster.org/20008 (gfapi: various broken symbol versions) posted (#2) for review on release-4.0 by Kaleb KEITHLEY
This bug reported is against a version of Gluster that is no longer maintained (or has been EOL'd). See https://www.gluster.org/release-schedule/ for the versions currently maintained.
As a result this bug is being closed.
If the bug persists on a maintained version of gluster or against the mainline gluster repository, request that it be reopened and the Version field be marked appropriately.