Bug 1578151 - Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL
Summary: Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1578152
TreeView+ depends on / blocked
 
Reported: 2018-05-14 22:27 UTC by Emmanuel Seyman
Modified: 2018-05-26 20:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-26 20:41:14 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2018-05-14 22:27:59 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Mojo-Pg/perl-Mojo-Pg.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Mojo-Pg/perl-Mojo-Pg-4.08-1.fc28.src.rpm
Description:
Mojo::Pg is a tiny wrapper around DBD::Pg that makes PostgreSQL a lot of
fun to use with the Mojolicious real-time web framework. Perform queries
blocking and non-blocking, use all SQL features PostgreSQL has to offer,
generate CRUD queries from data structures, manage your database schema
with migrations and build scalable real-time web applications with the
publish/subscribe pattern.

Fedora Account System Username: eseyman
Rpmlint Output:
perl-Mojo-Pg.noarch: W: spelling-error Summary(en_US) Mojolicious -> Malicious
perl-Mojo-Pg.src: W: spelling-error Summary(en_US) Mojolicious -> Malicious
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Comment 1 Jitka Plesnikova 2018-05-15 07:47:05 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Mojo-Pg-4.08-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(constant)
      1 perl(DBD::Pg)
      1 perl(DBI)
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Mojo::Base)
      1 perl(Mojo::Collection)
      1 perl(Mojo::File)
      1 perl(Mojo::IOLoop)
      1 perl(Mojo::JSON)
      1 perl(Mojo::Loader)
      1 perl(Mojo::Pg::Database)
      1 perl(Mojo::Pg::Migrations)
      1 perl(Mojo::Pg::PubSub)
      1 perl(Mojo::Pg::Results)
      1 perl(Mojo::Pg::Transaction)
      1 perl(Mojo::Promise)
      1 perl(Mojo::URL)
      1 perl(Mojo::Util)
      1 perl(Scalar::Util)
      1 perl(SQL::Abstract::Pg)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

FIX: Please add run-requires
     perl(SQL::Abstract) >= 1.85 (lib/SQL/Abstract/Pg.pm:2 and Makefile.PL:33)

TODO: Please consider adding following versioned run-requires (Makefile.PL:33)
     perl(DBD::Pg) >= 3.005001
     perl(Mojolicious) >= 7.53

$ rpm -qp --provides perl-Mojo-Pg-4.08-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Mojo::Pg) = 4.08
      1 perl-Mojo-Pg = 4.08-1.fc29
      1 perl(Mojo::Pg::Database)
      1 perl(Mojo::Pg::Migrations)
      1 perl(Mojo::Pg::PubSub)
      1 perl(Mojo::Pg::Results)
      1 perl(Mojo::Pg::Transaction)
      1 perl(SQL::Abstract::Pg)
Binary provides are Ok.

$ rpmlint ./perl-Mojo-Pg*
perl-Mojo-Pg.noarch: W: spelling-error Summary(en_US) Mojolicious -> Malicious
perl-Mojo-Pg.src: W: spelling-error Summary(en_US) Mojolicious -> Malicious
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please correct all 'FIX' issues and consider fixing 'TODO' items.

Otherwise the package looks good.
Approved

Comment 2 Emmanuel Seyman 2018-05-15 08:28:41 UTC
(In reply to Jitka Plesnikova from comment #1)
> 
> FIX: Please add run-requires
>      perl(SQL::Abstract) >= 1.85 (lib/SQL/Abstract/Pg.pm:2 and
> Makefile.PL:33)

Done.

> TODO: Please consider adding following versioned run-requires
> (Makefile.PL:33)
>      perl(DBD::Pg) >= 3.005001

I've used the version 3.5.1 since that's the format the perl-DBD-Pg package uses.

>      perl(Mojolicious) >= 7.53

Grumble... Done.

> Please correct all 'FIX' issues and consider fixing 'TODO' items.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Mojo-Pg/perl-Mojo-Pg.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Mojo-Pg/perl-Mojo-Pg-4.08-2.fc28.src.rpm

> Otherwise the package looks good.
> Approved

Thank you for the review, Jitka.

Comment 3 Gwyn Ciesla 2018-05-15 12:53:16 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Mojo-Pg

Comment 4 Fedora Update System 2018-05-15 16:10:38 UTC
perl-Mojo-Pg-4.08-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2c189241db

Comment 5 Fedora Update System 2018-05-16 03:27:35 UTC
perl-Mojo-Pg-4.08-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2c189241db

Comment 6 Fedora Update System 2018-05-26 20:41:14 UTC
perl-Mojo-Pg-4.08-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.