Bug 1578152 - Review Request: perl-Minion - High performance job queue for the Perl programming language
Summary: Review Request: perl-Minion - High performance job queue for the Perl program...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: NotReady
Depends On: 1578151
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-14 22:38 UTC by Emmanuel Seyman
Modified: 2018-06-05 13:43 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-06-05 13:43:26 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2018-05-14 22:38:30 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Minion/perl-Minion.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Minion/perl-Minion-9.03-1.fc28.src.rpm
Description:
Minion is a high performance job queue for the Perl programming language,
with support for multiple named queues, priorities, delayed jobs, job
dependencies, job progress, job results, retries with back-off, rate
limiting, unique jobs, statistics, distributed workers, parallel
processing, auto-scaling, remote control, Mojolicious admin UI, resource
leak protection and multiple backends (such as PostgreSQL).

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2018-05-17 07:09:13 UTC
Source file is ok

License of Minion is Artistic 2.0
FIX: Please add also license 'MIT' and 'OFL', because Minion includes a few
     files with different licenses. More info can be found in
     Minion-9.03/lib/Minion.pm line 803 and in files bootstrap.css,
     bootstrap.js, fontawesome.css, popper.js

Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Minion-9.03-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(Config)
      1 perl(Minion)
      1 perl(Minion::Job)
      1 perl(Minion::Worker)
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Mojo::Base)
      1 perl(Mojo::Date)
      1 perl(Mojo::File)
      1 perl(Mojo::IOLoop)
      1 perl(Mojo::JSON)
      1 perl(Mojo::Loader)
      1 perl(Mojo::Pg) >= 4.0
      1 perl(Mojo::Server)
      1 perl(Mojo::Util)
      1 perl(POSIX)
      1 perl(Scalar::Util)
      1 perl(Sys::Hostname)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Minion-9.03-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Minion) = 9.03
      1 perl-Minion = 9.03-1.fc29
      1 perl(Minion::Backend)
      1 perl(Minion::Backend::Pg)
      1 perl(Minion::Command::minion)
      1 perl(Minion::Command::minion::job)
      1 perl(Minion::Command::minion::worker)
      1 perl(Minion::_Guard)
      1 perl(Minion::Job)
      1 perl(Minion::Worker)
      1 perl(Mojolicious::Plugin::Minion)
      1 perl(Mojolicious::Plugin::Minion::Admin)
Binary provides are Ok.

$ rpmlint ./perl-Minion*
perl-Minion.noarch: W: summary-not-capitalized C a high performance job queue for the Perl programming language
perl-Minion.noarch: W: spelling-error %description -l en_US backoff -> back off, back-off, kickoff
perl-Minion.noarch: W: spelling-error %description -l en_US autoscaling -> auto scaling, auto-scaling, automobiling
perl-Minion.noarch: W: spelling-error %description -l en_US ui -> ii, u, i
perl-Minion.src: W: summary-not-capitalized C a high performance job queue for the Perl programming language
perl-Minion.src: W: spelling-error %description -l en_US backoff -> back off, back-off, kickoff
perl-Minion.src: W: spelling-error %description -l en_US autoscaling -> auto scaling, auto-scaling, automobiling
perl-Minion.src: W: spelling-error %description -l en_US ui -> ii, u, i
2 packages and 1 specfiles checked; 0 errors, 8 warnings.

Summary is ok
FIX: Just replace 'a high' with 'A high'

Please correct all 'FIX' issues.

Otherwise the package looks good.
Approved

Comment 2 Emmanuel Seyman 2018-05-19 20:27:41 UTC
(In reply to Jitka Plesnikova from comment #1)
>
> License of Minion is Artistic 2.0
> FIX: Please add also license 'MIT' and 'OFL', because Minion includes a few
>      files with different licenses. More info can be found in
>      Minion-9.03/lib/Minion.pm line 803 and in files bootstrap.css,
>      bootstrap.js, fontawesome.css, popper.js

Done.

> Summary is ok
> FIX: Just replace 'a high' with 'A high'

I went with 'High'. The article 'A' isn't of much use here.

I also corrected the spelling mistakes and changed the Source URL to metacpan (since search.cpan.org is going the way of the dodo).

> Please correct all 'FIX' issues.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Minion/perl-Minion.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Minion/perl-Minion-9.03-2.fc28.src.rpm

> Otherwise the package looks good.
> Approved

Thank you for the review, Jikta. Repo requested.

Comment 3 Gwyn Ciesla 2018-05-20 18:09:24 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Minion

Comment 4 Fedora Update System 2018-05-27 08:54:58 UTC
perl-Minion-9.03-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f73f93fe60

Comment 5 Fedora Update System 2018-05-27 22:13:47 UTC
perl-Minion-9.03-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f73f93fe60

Comment 6 Fedora Update System 2018-06-05 13:43:26 UTC
perl-Minion-9.03-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.