Bug 1578418 - Checks on bond mode are not effective
Summary: Checks on bond mode are not effective
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-hosted-engine-setup
Classification: oVirt
Component: Network
Version: 2.2.19
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ovirt-4.2.4
: 2.2.21
Assignee: Ido Rosenzwig
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks: ovirt-hosted-engine-setup-2.2.22
TreeView+ depends on / blocked
 
Reported: 2018-05-15 14:29 UTC by Simone Tiraboschi
Modified: 2018-06-26 08:34 UTC (History)
3 users (show)

Fixed In Version: ovirt-hosted-engine-setup-2.2.21
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-26 08:34:53 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 91262 0 master MERGED The bond mode '802.3ad' was incorrectly typed as '802.3adq' 2021-01-08 08:07:16 UTC
oVirt gerrit 91272 0 master MERGED Ansible: Fix check for invalid bond modes for ovirtmgmt bridge 2021-01-08 08:07:16 UTC
oVirt gerrit 91276 0 ovirt-hosted-engine-setup-2.2 MERGED Ansible: Fix check for invalid bond modes for ovirtmgmt bridge 2021-01-08 08:07:16 UTC
oVirt gerrit 91278 0 ovirt-hosted-engine-setup-2.2 MERGED The bond mode '802.3ad' was incorrectly typed as '802.3adq' 2021-01-08 08:07:16 UTC

Internal Links: 1584016

Description Simone Tiraboschi 2018-05-15 14:29:50 UTC
Description of problem:
The user can try to deploy hosted-engine choosing a bond interface with invalid mode (0, 5, 6) and it will fail really late.

Version-Release number of selected component (if applicable):
2.2.20

How reproducible:
100%

Steps to Reproduce:
1. configure a bond in mode 0, 5 or 6
2. try to deploy hosted-engine choosing that bond
3. 

Actual results:
The bond will be accepted but the host will be set as non operational by the engine due to:
WARN  [org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand] (EE-ManagedThreadFactory-engine-Thread-1) [1408d11e] Validation of action 'HostSetupNetworks' failed for user admin@internal-authz. Reasons: VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,INVALID_BOND_MODE_FOR_BOND_WITH_VM_NETWORK,$BondName bond0,$networkName ovirtmgmt

Expected results:
the user is not allowed to choose an invalid bond interface fro hosted-engine

Additional info:

Comment 1 Simone Tiraboschi 2018-05-15 14:31:29 UTC
(In reply to Simone Tiraboschi from comment #0)
> Additional info:

The code checks for 802.3adq instead of 802.3ad

Comment 2 Yaniv Kaul 2018-05-16 07:23:18 UTC
Severity...?

Comment 3 Yaniv Kaul 2018-05-24 10:11:59 UTC
(In reply to Yaniv Kaul from comment #2)
> Severity...?

Comment 4 Michael Burman 2018-06-01 10:28:48 UTC
Verified on - 
ovirt-hosted-engine-ha-2.2.13-1.el7ev.noarch
ovirt-hosted-engine-setup-2.2.22-1.el7ev.noarch

Cockpit - 
IF the host active connection is on top of a bond mode=0,5,6, the HE wizard won't be loaded and we failing with a very generic error:

'System data could not be retrieved!'

Can't start the HE deploy in such scenario, but we must to handle this generic error, will report a fresh bug to handle this. 

CLI-
If the host active connection is on top of a bond mode-0,5,6, the HE deploy is failed:
[ ERROR ] Failed to execute stage 'Environment customization': A Network interface is required
[ ERROR ] Hosted Engine deployment failed

Comment 5 Michael Burman 2018-06-03 09:11:22 UTC
Created new bug to handle the generic error on cockpit side - BZ 1585462

Comment 6 Sandro Bonazzola 2018-06-26 08:34:53 UTC
This bugzilla is included in oVirt 4.2.4 release, published on June 26th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.