Bug 1585462

Does this work on the CLI?

(In reply to Ryan Barry from comment #1)
> Does this work on the CLI?

It fails on CLI as well as expected. In both ways, HE shouldn't start if the bond is mode=0,5,6 and has the host active connection. 

Cockpit - 
IF the host active connection is on top of a bond mode=0,5,6, the HE wizard won't be loaded and we failing with a very generic error:

'System data could not be retrieved!'

Can't start the HE deploy in such scenario, but we must to handle this generic error, will report a fresh bug to handle this. 

CLI-
If the host active connection is on top of a bond mode-0,5,6, the HE deploy is failed:
[ ERROR ] Failed to execute stage 'Environment customization': A Network interface is required
[ ERROR ] Hosted Engine deployment failed

Failure here is the expected behaviour, but the generic error on cockpit side should be improved.

Created attachment 1472885 [details]
mode6_error_cockpit

Can reproduce.

Use version:
rhvh-4.2.5.1-0.20180801.0+1
ovirt-hosted-engine-ha-2.2.16-1.el7ev.noarch
ovirt-hosted-engine-setup-2.2.25-1.el7ev.noarch
cockpit-ovirt-dashboard-0.11.31-1.el7ev.noarch
rhvm-appliance-4.2-20180801.0.el7.noarch


Test steps:
1. Configure the network with mode 6
2. Deploy HE via cockpit.

Result:
The same as the description.
mode6_error_cockpit

Created attachment 1744308 [details]
naming conventions for VLAN and bonds

Can't reproduce

Version tested:
ovirt-node-ng-installer-4.4.4-2020121712.el8
cockpit-ovirt-dashboard-0.14.17-1.el8.noarch
ovirt-hosted-engine-setup-2.4.9-1.el8.noarch
ovirt-hosted-engine-ha-2.4.5-1.el8.noarch
ovirt-release44-pre-4.4.4-0.6.rc6.el8.noarch

Steps taken:
1. Configured bonded network interface with mode 0 balance-rr (Round Robin)
2. Started HE installation via cockpit, recieved following massage boxes:
A. "System data could not be retrieved!"
B. "No valid network interface has been found
If you are using Bonds or VLANs Use the following naming conventions:
- VLAN interfaces: physical_device.VLAN_ID (for example, eth0.23, eth1.128, enp3s0.50)
- Bond interfaces: bond*number* (for example, bond0, bond1)
- VLANs on bond interfaces: bond*number*.VLAN_ID (for example, bond0.50, bond1.128)
* Supported bond modes: active-backup, balance-xor, broadcast, 802.3ad
* Networking teaming is not supported and will cause errors"

screenshot of error is attached to this comment.

Created attachment 1744309 [details]
bond mode 0

Created attachment 1744310 [details]
existing networks available

Moving to QE as per comment #5 this should be already fixed.

Test Version:
rhvh-4.4.4.1-0.20210106.0
cockpit-ws-224.2-1.el8.x86_64
cockpit-224.2-1.el8.x86_64
cockpit-ovirt-dashboard-0.14.17-1.el8ev.noarch
cockpit-bridge-224.2-1.el8.x86_64
cockpit-system-224.2-1.el8.noarch
cockpit-storaged-224.2-1.el8.noarch
subscription-manager-cockpit-1.27.16-1.el8.noarch
cockpit-dashboard-224.2-1.el8.noarch

Test step:
1. Setup bond2(using mode 0 rr) with cockpit UI
2. Go to hosted engine deployment to start hosted engine deploying

Result:
Cannot get the right massage boxes in cockpit UI, the HE wizard displays.

Maybe I used wrong test steps. Could dev help to correct me? thanks

BTW:
I also test vlan over the bond2(using mode 0 rr) to deploy hosted engine, HE installation is failed, but still no the right massage boxes in cockpit UI.

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

According to comment 9, move it to "ASSIGNED"

Created attachment 1756343 [details]
network naming info label

(In reply to Wei Wang from comment #9)

> Test step:
> 1. Setup bond2(using mode 0 rr) with cockpit UI
> 2. Go to hosted engine deployment to start hosted engine deploying
> 
> Result:
> Cannot get the right massage boxes in cockpit UI, the HE wizard displays.
Hi Wei,

I got 2 different situations when trying to reproduce:
1. My env is connected only to unsupported bond mode 'bond0', in this case I received the proper message boxes, and cockpit-UI wizard is not displaying at all.

2. When using more then one connections to my env, 'bond0' as unsupported bond mode and 'ens3' , in this case cockpit-UI wizard is displaying without showing box-messages and when trying to choose a network,
the bond is not appearing in the list of networks we can choose from, which is the expected behavior, but could be confusing.

My suggestion (2.):
Adding to cockpit-UI an info icon that can clearify naming conventions as constant, (I've added an example of how it might look on wizard)


> Maybe I used wrong test steps. Could dev help to correct me? thanks
> 
> BTW:
> I also test vlan over the bond2(using mode 0 rr) to deploy hosted engine, HE
> installation is failed, but still no the right massage boxes in cockpit UI.

that make sense since still using the unsupported bond, but IMO the vlan is also needed to be filtered out, since using the unsupported bond mode

Created attachment 1756345 [details]
network naming info label correct position in UI

https://github.com/oVirt/ovirt-ansible-collection/commit/2f49d4edb944d37ead39eccad1529ca85c654782 is included in ovirt-ansible-collection-1.4.0

The latest RHVH build RHVH-4.4-20210413.0-RHVH-x86_64-dvd1.iso has https://bugzilla.redhat.com/show_bug.cgi?id=1946095 issue, so QE will verify this bug after BZ 1946095 is fixed.

Test with RHVH-4.4-20210510.0-RHVH-x86_64-dvd1.iso (ovirt-ansible-collection-1.4.2-1.el8ev.noarch)

Test scenarios
1. My env is connected only to unsupported bond mode 'bond0'
Yes, I got the right proper message boxes, and cockpit-ui wizard is not displaying at all. 

2. When using more then one connections to my env, 'bond0' as unsupported bond mode and 'ens3'.
Yes, I got the expected result.
Cockpit-UI wizard is displaying without showing box-messages and when trying to choose a network, the bond is not appearing in the list of networks we can choose from, but there is a prompt of help to show the message boxes.

Bug is fixed, move it to "VERIFIED"