Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/libsmbios-cpp/epel-7-x86_64/00758209-libsmbios-cpp/libsmbios-cpp.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/libsmbios-cpp/epel-7-x86_64/00758209-libsmbios-cpp/libsmbios-cpp-2.3.3-1.el7.src.rpm COPR: https://copr.fedorainfracloud.org/coprs/carlwgeorge/libsmbios-cpp/ Description: Libsmbios is a library and utilities that can be used by client programs to get information from standard BIOS tables, such as the SMBIOS table. This package provides the C++-based libsmbios library, with a C++ interface. It is not actively maintained, but provided for backwards compatibility. New programs should use the libsmbios C interface. Fedora Account System Username: carlwgeorge Justification for this package is explained in further detail in these EPEL meeting notes (from 18:03:43 to 18:27:48). https://meetbot.fedoraproject.org/fedora-meeting/2018-05-16/epel.2018-05-16-18.00.log.html
This package is for EPEL7 only.
I get this # -- rpmlint starts -- rpmlint version 1.5 Copyright (C) 1999-2007 Frederic Lepied, Mandriva libsmbios-cpp.src:58: W: configure-without-libdir-spec libsmbios-cpp.src:62: W: configure-without-libdir-spec libsmbios-cpp.src:63: W: configure-without-libdir-spec libsmbios-cpp.src: W: patch-not-applied Patch0: disable-unwanted-components.patch ./holding/libsmbios-cpp.spec:58: W: configure-without-libdir-spec ./holding/libsmbios-cpp.spec:62: W: configure-without-libdir-spec ./holding/libsmbios-cpp.spec:63: W: configure-without-libdir-spec ./holding/libsmbios-cpp.spec: W: patch-not-applied Patch0: disable-unwanted-components.patch 1 packages and 1 specfiles checked; 0 errors, 8 warnings. # -- rpmlint ends --
> libsmbios-cpp.src:58: W: configure-without-libdir-spec > libsmbios-cpp.src:62: W: configure-without-libdir-spec > libsmbios-cpp.src:63: W: configure-without-libdir-spec I think these are false positives based on searching for the string "./configure". Lines 58, 62, and 63 all happen to contain that string, but aren't actually executing the configure script. Besides, that section of %build was lifted directly from the RHEL spec file. > libsmbios-cpp.src: W: patch-not-applied Patch0: disable-unwanted-components.patch Another false positive. Patch0 is applied via the %autosetup macro. Fedora's rpmlint is aware of this and doesn't return this warning.
Created attachment 1446357 [details] Review done by user This covers the files needed to show that a review was done and that the items which fedora-review flagged were checked and confirmed to be ok for EL-7
After much searching and clicking.. I found the correct review button.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libsmbios-cpp
libsmbios-cpp-2.3.3-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-b03a9eeb2f
libsmbios-cpp-2.3.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-b03a9eeb2f
libsmbios-cpp-2.3.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.