RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1584097 - Review-request: pmu-tools - Intel PMU profiling tools
Summary: Review-request: pmu-tools - Intel PMU profiling tools
Keywords:
Status: CLOSED DUPLICATE of bug 1705981
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: trunk
Assignee: hguemar
QA Contact: hguemar
URL:
Whiteboard:
Depends On:
Blocks: 1410045 1721280
TreeView+ depends on / blocked
 
Reported: 2018-05-30 09:32 UTC by Matthias Runge
Modified: 2019-07-05 06:18 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-07-05 06:18:20 UTC
Embargoed:


Attachments (Terms of Use)

Description Matthias Runge 2018-05-30 09:32:58 UTC
SPEC: http://matthias-runge.de/fedora/pmu-tools.spec
SRPM: http://matthias-runge.de/fedora/pmu-tools-107-1.fc28.src.rpm

Description: 
pmu tools is a collection of tools for profile collection and performance
analysis on Intel CPUs on top of Linux perf. This uses performance counters
in the CPU.


I currently only need the jevents subpackage here as depedency for the collectd-pmu plugin.


rpmlint ./pmu-tools.spec ../SRPMS/pmu-tools-107-1.fc28.src.rpm ../RPMS/x86_64/pmu-tools-107-1.fc28.x86_64.rpm ../RPMS/x86_64/jevents-107-1.fc28.x86_64.rpm ../RPMS/x86_64/jevents-devel-107-1.fc28.x86_64.rpm 
./pmu-tools.spec:38: W: rpm-buildroot-usage %prep sed -i -e 's|PREFIX :=.*|PREFIX := %{buildroot}/usr|' Makefile
pmu-tools.src: W: spelling-error %description -l en_US perf -> pref, per, serf
pmu-tools.src:38: W: rpm-buildroot-usage %prep sed -i -e 's|PREFIX :=.*|PREFIX := %{buildroot}/usr|' Makefile
pmu-tools.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf
pmu-tools.x86_64: E: no-binary
pmu-tools.x86_64: E: incorrect-fsf-address /usr/share/licenses/pmu-tools/COPYING
jevents.x86_64: W: spelling-error Summary(en_US) perf -> pref, per, serf
jevents.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf
jevents.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libjevents.a
jevents.x86_64: E: incorrect-fsf-address /usr/share/licenses/jevents/COPYING
jevents.x86_64: W: no-manual-page-for-binary event-rmap
jevents.x86_64: W: no-manual-page-for-binary listevents
jevents.x86_64: W: no-manual-page-for-binary showevent
jevents-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 3 errors, 11 warnings.


- yes, there are no man pages
- yes, agreed, the fsf address is wrong
- the makefile uses hard coded paths, which make it unsuitable for distros.

Comment 1 Matthias Runge 2019-07-05 06:18:20 UTC

*** This bug has been marked as a duplicate of bug 1705981 ***


Note You need to log in before you can comment on or make changes to this bug.