SPEC: http://www.matthias-runge.de/fedora/pmu-tools.spec SRPM: http://www.matthias-runge.de/fedora/pmu-tools-108-1.fc30.src.rpm Description: pmu tools is a collection of tools for profile collection and performance analysis on Intel CPUs on top of Linux perf. This uses performance counters in the CPU.
Comments: - Should libjevents.a be installed as part of jevents-devel instead of jevents? - Some of the files are licensed under the 2-clause BSD license, but only GPL is listed in the spec and only the text of the GPL license is installed a doc file. - The GPL license text is stale and has the old address. May be worth nagging upstream to update that. - What is the purpose of the pmu-tools package? It looks like it only installs doc files? Is this intended? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: jevents. Illegal package name: jevents. Does not provide -static: jevents. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License", "Expat License", "*No copyright* BSD (unspecified)", "BSD 2-clause "Simplified" License GNU General Public License (v2)". 156 files have unknown license. Detailed output of licensecheck in /home/ryan/1705981-pmu-tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pmu- tools , jevents , jevents-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pmu-tools-108-1.fc31.x86_64.rpm jevents-108-1.fc31.x86_64.rpm jevents-devel-108-1.fc31.x86_64.rpm pmu-tools-debugsource-108-1.fc31.x86_64.rpm pmu-tools-108-1.fc31.src.rpm pmu-tools.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf pmu-tools.x86_64: E: no-binary pmu-tools.x86_64: E: incorrect-fsf-address /usr/share/licenses/pmu-tools/COPYING jevents.x86_64: W: spelling-error Summary(en_US) perf -> pref, per, serf jevents.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf jevents.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libjevents.a jevents.x86_64: E: incorrect-fsf-address /usr/share/licenses/jevents/COPYING jevents.x86_64: W: no-manual-page-for-binary event-rmap jevents.x86_64: W: no-manual-page-for-binary listevents jevents.x86_64: W: no-manual-page-for-binary showevent jevents-devel.x86_64: W: no-documentation pmu-tools.src: W: spelling-error %description -l en_US perf -> pref, per, serf pmu-tools.src:39: W: rpm-buildroot-usage %prep sed -i -e 's|PREFIX=.*|PREFIX= %{buildroot}/usr|' Makefile 5 packages and 0 specfiles checked; 3 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sh: /usr/bin/python: No such file or directory /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') jevents-devel.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> jevents-devel.x86_64: W: no-documentation pmu-tools-debugsource.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> pmu-tools.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf pmu-tools.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> pmu-tools.x86_64: E: no-binary pmu-tools.x86_64: E: incorrect-fsf-address /usr/share/licenses/pmu-tools/COPYING /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') jevents.x86_64: W: spelling-error Summary(en_US) perf -> pref, per, serf jevents.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf jevents.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') jevents.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libjevents.a jevents.x86_64: E: incorrect-fsf-address /usr/share/licenses/jevents/COPYING jevents.x86_64: W: no-manual-page-for-binary event-rmap jevents.x86_64: W: no-manual-page-for-binary listevents jevents.x86_64: W: no-manual-page-for-binary showevent 4 packages and 0 specfiles checked; 3 errors, 12 warnings. Source checksums ---------------- https://github.com/andikleen/pmu-tools/archive/r108.tar.gz#/pmu-tools-108.tar.gz : CHECKSUM(SHA256) this package : 6833c69adada72f169ac900fe1538920d70d481eaa726d2e0bf06876bf81edb7 CHECKSUM(SHA256) upstream package : 6833c69adada72f169ac900fe1538920d70d481eaa726d2e0bf06876bf81edb7 Requires -------- pmu-tools (rpmlib, GLIBC filtered): jevents (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) jevents-devel (rpmlib, GLIBC filtered): jevents pmu-tools-debugsource (rpmlib, GLIBC filtered): Provides -------- pmu-tools: pmu-tools pmu-tools(x86-64) jevents: jevents jevents(x86-64) jevents-devel: jevents-devel jevents-devel(x86-64) pmu-tools-debugsource: pmu-tools-debugsource pmu-tools-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1705981 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: PHP, Haskell, SugarActivity, Ocaml, Python, Java, R, fonts, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Ryan McCabe from comment #1) > Comments: > > - Should libjevents.a be installed as part of jevents-devel instead of > jevents? > - Some of the files are licensed under the 2-clause BSD license, but only > GPL is listed in the spec and only > the text of the GPL license is installed a doc file. > - The GPL license text is stale and has the old address. May be worth > nagging upstream to update that. > - What is the purpose of the pmu-tools package? It looks like it only > installs doc files? Is this intended? > Right, libjevents.a should be installed as part of jevents-devel. I fixed the license tag, jevents seems to be licensed under BSD I'll get the license file itself updated. pmu-tools package is a kind of container; it will be needed later on, and it's the parent of all included packages. It also provides python scripts, which I chose to not include this time. The python scripts can be used to download cpu data from an Intel server, for example. Updated SPEC: http://www.matthias-runge.de/fedora/pmu-tools.spec SRPM: http://www.matthias-runge.de/fedora/pmu-tools-108-2.fc30.src.rpm
Review for -2 We need an explicit "Provides:" for the static lib. My fault for missing this above. I think "Provides: jevents-devel-static = %{version}-%{release}" for jevents-devel should do it. Everything else looks good. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: jevents-devel. Does not provide -static: jevents-devel. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License", "Expat License", "*No copyright* BSD (unspecified)", "BSD 2-clause "Simplified" License GNU General Public License (v2)". 156 files have unknown license. Detailed output of licensecheck in /home/ryan/1705981-pmu-tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pmu- tools , jevents , jevents-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pmu-tools-108-2.fc31.x86_64.rpm jevents-108-2.fc31.x86_64.rpm jevents-devel-108-2.fc31.x86_64.rpm pmu-tools-debugsource-108-2.fc31.x86_64.rpm pmu-tools-108-2.fc31.src.rpm pmu-tools.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf pmu-tools.x86_64: E: no-binary pmu-tools.x86_64: E: incorrect-fsf-address /usr/share/licenses/pmu-tools/COPYING jevents.x86_64: W: spelling-error Summary(en_US) perf -> pref, per, serf jevents.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf jevents.x86_64: E: incorrect-fsf-address /usr/share/licenses/jevents/COPYING jevents.x86_64: W: no-manual-page-for-binary event-rmap jevents.x86_64: W: no-manual-page-for-binary listevents jevents.x86_64: W: no-manual-page-for-binary showevent jevents-devel.x86_64: W: no-documentation pmu-tools.src: W: spelling-error %description -l en_US perf -> pref, per, serf pmu-tools.src:39: W: rpm-buildroot-usage %prep sed -i -e 's|PREFIX=.*|PREFIX= %{buildroot}/usr|' Makefile 5 packages and 0 specfiles checked; 3 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sh: /usr/bin/python: No such file or directory /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') jevents.x86_64: W: spelling-error Summary(en_US) perf -> pref, per, serf jevents.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf jevents.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') jevents.x86_64: E: incorrect-fsf-address /usr/share/licenses/jevents/COPYING jevents.x86_64: W: no-manual-page-for-binary event-rmap jevents.x86_64: W: no-manual-page-for-binary listevents jevents.x86_64: W: no-manual-page-for-binary showevent /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') jevents-devel.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') jevents-devel.x86_64: W: no-documentation pmu-tools.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf pmu-tools.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> pmu-tools.x86_64: E: no-binary pmu-tools.x86_64: E: incorrect-fsf-address /usr/share/licenses/pmu-tools/COPYING /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') pmu-tools-debugsource.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> 4 packages and 0 specfiles checked; 3 errors, 11 warnings. Source checksums ---------------- https://github.com/andikleen/pmu-tools/archive/r108.tar.gz#/pmu-tools-108.tar.gz : CHECKSUM(SHA256) this package : 6833c69adada72f169ac900fe1538920d70d481eaa726d2e0bf06876bf81edb7 CHECKSUM(SHA256) upstream package : 6833c69adada72f169ac900fe1538920d70d481eaa726d2e0bf06876bf81edb7 Requires -------- pmu-tools (rpmlib, GLIBC filtered): jevents (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) jevents-devel (rpmlib, GLIBC filtered): jevents pmu-tools-debugsource (rpmlib, GLIBC filtered): Provides -------- pmu-tools: pmu-tools pmu-tools(x86-64) jevents: jevents jevents(x86-64) jevents-devel: jevents-devel jevents-devel(x86-64) pmu-tools-debugsource: pmu-tools-debugsource pmu-tools-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1705981 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: fonts, PHP, Java, Python, R, Ocaml, SugarActivity, Perl, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
I've fixed the SPEC and SRPM SPEC: http://www.matthias-runge.de/fedora/pmu-tools.spec SRPM: http://www.matthias-runge.de/fedora/pmu-tools-108-3.fc30.src.rpm For the COPYING file, I've opened https://github.com/andikleen/pmu-tools/issues/175 and https://github.com/andikleen/pmu-tools/pull/176 to fix the issue.
Looks good now. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License", "Expat License", "*No copyright* BSD (unspecified)", "BSD 2-clause "Simplified" License GNU General Public License (v2)". 156 files have unknown license. Detailed output of licensecheck in /home/ryan/rev/1705981-pmu-tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: jevents-devel. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pmu- tools , jevents , jevents-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pmu-tools-108-3.fc31.x86_64.rpm jevents-108-3.fc31.x86_64.rpm jevents-devel-108-3.fc31.x86_64.rpm pmu-tools-debugsource-108-3.fc31.x86_64.rpm pmu-tools-108-3.fc31.src.rpm pmu-tools.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf pmu-tools.x86_64: E: no-binary pmu-tools.x86_64: E: incorrect-fsf-address /usr/share/licenses/pmu-tools/COPYING jevents.x86_64: W: spelling-error Summary(en_US) perf -> pref, per, serf jevents.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf jevents.x86_64: E: incorrect-fsf-address /usr/share/licenses/jevents/COPYING jevents.x86_64: W: no-manual-page-for-binary event-rmap jevents.x86_64: W: no-manual-page-for-binary listevents jevents.x86_64: W: no-manual-page-for-binary showevent jevents-devel.x86_64: W: no-documentation pmu-tools.src: W: spelling-error %description -l en_US perf -> pref, per, serf pmu-tools.src:41: W: rpm-buildroot-usage %prep sed -i -e 's|PREFIX=.*|PREFIX= %{buildroot}/usr|' Makefile 5 packages and 0 specfiles checked; 3 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sh: /usr/bin/python: No such file or directory /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') jevents-devel.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') jevents-devel.x86_64: W: no-documentation jevents.x86_64: W: spelling-error Summary(en_US) perf -> pref, per, serf jevents.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf jevents.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') jevents.x86_64: E: incorrect-fsf-address /usr/share/licenses/jevents/COPYING jevents.x86_64: W: no-manual-page-for-binary event-rmap jevents.x86_64: W: no-manual-page-for-binary listevents jevents.x86_64: W: no-manual-page-for-binary showevent /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') pmu-tools.x86_64: W: spelling-error %description -l en_US perf -> pref, per, serf pmu-tools.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> pmu-tools.x86_64: E: no-binary pmu-tools.x86_64: E: incorrect-fsf-address /usr/share/licenses/pmu-tools/COPYING /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') pmu-tools-debugsource.x86_64: W: invalid-url URL: https://github.com/andikleen/pmu-tools <urlopen error [Errno -2] Name or service not known> 4 packages and 0 specfiles checked; 3 errors, 11 warnings. Source checksums ---------------- https://github.com/andikleen/pmu-tools/archive/r108.tar.gz#/pmu-tools-108.tar.gz : CHECKSUM(SHA256) this package : 6833c69adada72f169ac900fe1538920d70d481eaa726d2e0bf06876bf81edb7 CHECKSUM(SHA256) upstream package : 6833c69adada72f169ac900fe1538920d70d481eaa726d2e0bf06876bf81edb7 Requires -------- pmu-tools (rpmlib, GLIBC filtered): jevents (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) jevents-devel (rpmlib, GLIBC filtered): jevents pmu-tools-debugsource (rpmlib, GLIBC filtered): Provides -------- pmu-tools: pmu-tools pmu-tools(x86-64) jevents: jevents jevents(x86-64) jevents-devel: jevents-devel jevents-devel(x86-64) jevents-static pmu-tools-debugsource: pmu-tools-debugsource pmu-tools-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1705981 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: R, Python, fonts, PHP, Perl, Ocaml, Haskell, SugarActivity, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
*** Bug 1584097 has been marked as a duplicate of this bug. ***
this has been imported to centos-opstools