Bug 1590828 - Associate Floating Ip to instance should not show already assigned IP in the list
Summary: Associate Floating Ip to instance should not show already assigned IP in the...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
urgent
Target Milestone: GA
: 5.9.4
Assignee: Gilles Dubreuil
QA Contact: Dave Johnson
URL:
Whiteboard:
Depends On:
Blocks: 1595269
TreeView+ depends on / blocked
 
Reported: 2018-06-13 12:46 UTC by Niladri Roy
Modified: 2022-03-13 15:06 UTC (History)
14 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-27 23:27:49 UTC
Category: ---
Cloudforms Team: Openstack
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Floating IP Reallocation (2.99 KB, text/plain)
2018-06-27 04:54 UTC, Gilles Dubreuil
no flags Details
Floating IP assignment via horizon dashboard (83.15 KB, image/png)
2018-06-27 08:37 UTC, Niladri Roy
no flags Details

Description Niladri Roy 2018-06-13 12:46:19 UTC
Description of problem:
While trying to assign floating IP, already assigned floating IPs can be assigned to other instances, this results in disassociation of the IP address from the already attached instance

Version-Release number of selected component (if applicable):
5.9.1.2

How reproducible:
Always

Steps to Reproduce:
1. two floating IPs under a tenant

  Floating IP  10.x.x.23 ---> assigned to Instance 192.x.x.6

  Floating IP 10.x.x.26  ---> Unassigned


2. After provider refresh, while trying to assign floating IP to instance 192.x.x.5, in the dropdown both floating IPs are shown

Expected:



3. Assigned 10.x.x.23  to 192.x.x.5



Actual results:
it removes the floating IP from old instance and assigns it to the other instance


Expected results:
Only unassigned floating IPs should be shown in dropdown

Additional info:

Comment 7 Gilles Dubreuil 2018-06-27 01:12:05 UTC
I'm taking over this one and will provide an update ASAP.

Comment 8 Gilles Dubreuil 2018-06-27 04:16:47 UTC
I confirm the issue, working on a patch.

Comment 9 Gilles Dubreuil 2018-06-27 04:54:29 UTC
Created attachment 1454904 [details]
Floating IP Reallocation

Comment 10 Gilles Dubreuil 2018-06-27 05:07:28 UTC
Let's take a step back. This is actually normal behaviour.

On OpenStack, being able to reallocate an already attached floating IP is default behaviour. A project owner of instances can therefore directly move a floating IP without having to de-allocate the IP before allocating it to another instance (see attachment https://bugzilla.redhat.com/attachment.cgi?id=1454904).

There is nothing wrong from the latter and that doesn't break anything inside OpenStack.

When allocating a floating IP, if the allocated IPs have disappeared from the list of available addresses then we're going to break the default feature. And therefore I  wouldn't recommend it.

Alternatively, we could request a confirmation windows when the floating IP is already assigned. This could be submitted as an RFE.

Comment 11 Niladri Roy 2018-06-27 08:36:41 UTC
Giles,

Thanks for looking into this.

I would disagree if it's a default behaviour because what you have shown is achievable from the OSP CLI only. From horizon dashboard the dropdown only lists the available (unassigned floating IPs) 

Please see attachment which shows the behaviour

- I had two floating IPs 10.x.x.48 and 10.x.x.49
- I assigned 10.x.x.48 to niroy-1 instance
- while assigning floating IP to niroy-2 instance only 10.x.x.49 is shown in the dropdown

Apart from this I see other issues with the network manager when we assign floating IP via CloudForms. It would be best if we can have a BJ session so that I show you the issue

Comment 12 Niladri Roy 2018-06-27 08:37:55 UTC
Created attachment 1454970 [details]
Floating IP assignment via horizon dashboard

Comment 13 Gilles Dubreuil 2018-06-27 13:25:28 UTC
Niladri,

Thank you for your prompt feedback.

Whether a floating IP can be reallocated directly or not is a feature choice.
The fact that currently a Floating IP can be re-allocated directly is not a bug.

I understand Horizon has made a different choice. If we want to change the current behaviour then that would have to go as an Request For Enhancement (RFE).

Let's keep one specific issue per BZ. If you're facing any other new issue please create a BZ accordingly.

Thanks

Comment 14 Niladri Roy 2018-06-27 14:02:14 UTC
Hello,

I have raised RFE 1595767 as per your suggestion. Clearing needinfo

Comment 15 Gilles Dubreuil 2018-06-27 23:27:49 UTC
Thanks for creating and following up upon BZ#1595767.


Note You need to log in before you can comment on or make changes to this bug.