Bug 1595767 - [RFE] Don't show allocated IPs in dropdown while assigning floating IPs via CloudForms
Summary: [RFE] Don't show allocated IPs in dropdown while assigning floating IPs via C...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: Gilles Dubreuil
QA Contact: Ido Ovadia
URL:
Whiteboard:
: 1650495 (view as bug list)
Depends On:
Blocks: 1623562
TreeView+ depends on / blocked
 
Reported: 2018-06-27 14:00 UTC by Niladri Roy
Modified: 2022-03-13 15:10 UTC (History)
15 users (show)

Fixed In Version: 5.10.0.25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1623562 (view as bug list)
Environment:
Last Closed: 2019-02-11 14:07:01 UTC
Category: ---
Cloudforms Team: Openstack
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
floatingip selection menu (55.69 KB, image/png)
2018-09-14 18:26 UTC, Luca Miccini
no flags Details

Comment 2 Bronagh Sorota 2018-06-27 14:55:40 UTC
Niladri
Which provider is this for?

thanks
Bronagh

Comment 3 Niladri Roy 2018-06-27 15:42:56 UTC
Hi Bronagh,

This is for OpenStack provider
this RFE is raised because of BZ 1590828

Comment 4 Bronagh Sorota 2018-06-27 16:04:50 UTC
Hi Niladri,

They look like duplicate BZs, can you clarify why we have both?

Thanks
Bronagh

Comment 5 Bronagh Sorota 2018-06-27 16:18:39 UTC
Further to my own question in #comment4, I closed BZ 1590828

Comment 6 Gilles Dubreuil 2018-06-27 23:38:11 UTC
Just to clarify 

BZ#1590828 was targeting CF 5.9.x and defined as a bug. 
This is an RFE for future CF versions and could be eventually ported back.

Some users might want to be able to reallocate Floating IPs directly while others might not want to and be forced to de-allocate them first. Since one cannot have both, any choice would make the other half unhappy. Alternatively have a preference option that toggle between the two, although that would be a bit more effort.

PM to help with the decision, please.

Comment 12 Bruno Gillet 2018-09-13 15:29:55 UTC
Hi,
So to avoid a duplicate I have search and found this RFE and it's ON_DEV counterpart.
I have a somewhat related, but also somewhat different issue on this topic.

(On cfme 5.9.4 vs. OSP 13)

If a user wants to allocate one of it's tenant free floating IPs, and that there are free floating IPs then they are correctly listed and he may do the thing perfectly.
Now, if there are no more free floating IPs for it's tenant he is proposed the totality of Floating IPs within all tenants, should they be allocated or free, without giving any clue about their status. He can make it's choice that will lead to nothing without error.

Is it an issue that will be addressed in this RFE or should I open a bugzilla for it ?

Thanks,
Bruno.

Comment 13 Luca Miccini 2018-09-14 18:25:33 UTC
(In reply to Gilles Dubreuil from comment #10)
> https://github.com/ManageIQ/manageiq-ui-classic/pull/4357

Gilles, is this the only change needed? I get a bunch of "undefined" by applying it to my test appliance (see screenshot).

thanks
Luca

Comment 14 Luca Miccini 2018-09-14 18:26:35 UTC
Created attachment 1483385 [details]
floatingip selection menu

Comment 15 Gilles Dubreuil 2018-09-17 11:08:02 UTC
@Luca,

Definitely not was is expected and what I experience. Let me test with latest 5.9 and get back to you.

Comment 16 Gilles Dubreuil 2018-09-17 11:12:21 UTC
In comment#15, please read

Definitely not what is expected...

Comment 17 Gilles Dubreuil 2018-09-17 11:21:32 UTC
@bruno,

The idea of this patch is to make sure to offer to the user only the list of available floating IPs by excluding the floating IPs which are already assigned to an instance.

If there are no more floating IPs available in the pool then the pool should be extended.

If that's not what you meant then please clarify.

Thanks

Comment 18 Bruno Gillet 2018-09-18 09:14:07 UTC
(In reply to Gilles Dubreuil from comment #17)
> @bruno,
> 
> The idea of this patch is to make sure to offer to the user only the list of
> available floating IPs by excluding the floating IPs which are already
> assigned to an instance.
> 
> If there are no more floating IPs available in the pool then the pool should
> be extended.
> 
> If that's not what you meant then please clarify.
> 
> Thanks

@Gilles,

Your precision is exactly what my concern is about. 
I was not sure asking at the good place, and the original description did not explicitely covered extra tenant floating IPs that may appear, and especially only as no more available Floating IPs existed in current user tenant. 
Thanks for the precision. 
This RFE totally covers the need.

Comment 19 Gilles Dubreuil 2018-11-19 07:45:40 UTC
Just tested latest upstream version and the list of floating IPs is not showing properly. Investigating.

Comment 20 Gilles Dubreuil 2018-11-20 06:55:01 UTC
Only the first filtered floating IP is returned 

The following contains the change to return a list:
https://github.com/ManageIQ/manageiq-ui-classic/pull/4944

The latter allows a non assigned floating IP can be associated to a VM.

Meanwhile if VM has already an address, it must be disassociated first.

Comment 21 CFME Bot 2018-11-20 14:43:33 UTC
New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/bf21dadc0908531b7ca2cf0397ea2a23b35cc8c6
commit bf21dadc0908531b7ca2cf0397ea2a23b35cc8c6
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Tue Nov 20 06:37:41 2018 -0500
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Tue Nov 20 06:37:41 2018 -0500

    Merge pull request #4944 from gildub/vm_cloud_floating_ip

    VM CLoud: floating ips to associate must be a list

    (cherry picked from commit 911a289574b1d433c6a8fcde890ebb39d7f24da2)

    https://bugzilla.redhat.com/show_bug.cgi?id=1595767

 app/controllers/mixins/actions/vm_actions/associate_floating_ip.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 22 Alexander Demicev 2018-11-28 13:22:35 UTC
*** Bug 1650495 has been marked as a duplicate of this bug. ***

Comment 23 Ido Ovadia 2018-12-17 09:47:28 UTC
Verified
========
5.10.0.28


Note You need to log in before you can comment on or make changes to this bug.