Red Hat Bugzilla – Bug 1591484
Reconfigure service fields empty after deploying service
Last modified: 2018-07-12 09:17:05 EDT
New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili: https://github.com/ManageIQ/manageiq-ui-classic/commit/962bcf3ebf22743fa9c3e0267f4c453e4ccbb2c1 commit 962bcf3ebf22743fa9c3e0267f4c453e4ccbb2c1 Author: Harpreet Kataria <hkataria@redhat.com> AuthorDate: Thu Jun 14 15:31:46 2018 -0400 Commit: Harpreet Kataria <hkataria@redhat.com> CommitDate: Thu Jun 14 15:31:46 2018 -0400 Merge pull request #4140 from eclarizio/BZ1580987 Ensure new dialog user component is used for service reconfiguration (cherry picked from commit e3c4096a9d3da88d18e098521130e6339734cd95) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591484 app/assets/javascripts/controllers/dialog_user/dialog_user_controller.js | 2 + app/controllers/service_controller.rb | 11 +- app/services/dialog_local_service.rb | 14 + spec/javascripts/controllers/dialog_user/dialog_user_controller.spec.js | 37 +- spec/services/dialog_local_service_spec.rb | 19 + 5 files changed, 76 insertions(+), 7 deletions(-)
Predefined values selected in dialog are not shown while reconfiguring service . Appliance : 10.8.196.133 Service : dynamic Steps : 1. Create a Generic Service 2. Specify an entry point for reconfigure(path doesn't matter) 3. Provision the Service 4. Reconfigure the Service to see if values specified in provisioning dialog are present.
https://github.com/ManageIQ/manageiq/pull/17647
https://github.com/ManageIQ/manageiq-ui-classic/pull/4226
New commit detected on ManageIQ/manageiq/gaprindashvili: https://github.com/ManageIQ/manageiq/commit/e33d35b833a01523280cdb17d049561753aadbc5 commit e33d35b833a01523280cdb17d049561753aadbc5 Author: Greg McCullough <gmccullo@redhat.com> AuthorDate: Fri Jun 29 08:49:55 2018 -0400 Commit: Greg McCullough <gmccullo@redhat.com> CommitDate: Fri Jun 29 08:49:55 2018 -0400 Merge pull request #17647 from eclarizio/BZ1591484-Reconfigure Change reconfigure setup to include values configured with originally (cherry picked from commit e13f77de072210a43d1ca0a1d7b7e8885f5936ed) https://bugzilla.redhat.com/show_bug.cgi?id=1591484 app/models/dialog.rb | 12 + app/models/dialog_field.rb | 4 + app/models/dialog_field_drop_down_list.rb | 5 + app/models/dialog_field_sorted_item.rb | 10 +- app/models/resource_action_workflow.rb | 2 + app/models/service.rb | 10 + spec/models/dialog_field_drop_down_list_spec.rb | 60 +- spec/models/dialog_field_radio_button_spec.rb | 96 - spec/models/dialog_field_sorted_item_spec.rb | 134 +- spec/models/dialog_field_spec.rb | 9 + spec/models/dialog_spec.rb | 37 + spec/models/resource_action_workflow_spec.rb | 9 + spec/models/service_spec.rb | 32 + 13 files changed, 142 insertions(+), 278 deletions(-)
https://github.com/ManageIQ/manageiq-ui-classic/pull/4236
New commits detected on ManageIQ/manageiq-ui-classic/gaprindashvili: https://github.com/ManageIQ/manageiq-ui-classic/commit/e79b2ce3e321166a5981843e8e0a538ffb135907 commit e79b2ce3e321166a5981843e8e0a538ffb135907 Author: Erik Clarizio <eclarizio@gmail.com> AuthorDate: Wed Jun 27 20:31:06 2018 -0400 Commit: Erik Clarizio <eclarizio@gmail.com> CommitDate: Wed Jun 27 20:31:06 2018 -0400 Change reconfigure setup to include values configured with originally https://bugzilla.redhat.com/show_bug.cgi?id=1591484 app/assets/javascripts/controllers/dialog_user/dialog_user_controller.js | 2 +- app/assets/javascripts/controllers/dialog_user/dialog_user_reconfigure_controller.js | 74 + app/controllers/application_controller/dialog_runner.rb | 3 + app/controllers/service_controller.rb | 28 +- app/services/dialog_local_service.rb | 14 - app/views/shared/dialogs/_reconfigure_dialog.html.haml | 25 + spec/controllers/service_controller_spec.rb | 29 + spec/services/dialog_local_service_spec.rb | 19 - 8 files changed, 144 insertions(+), 50 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/da230c6d9335b73af4acaaf110c9c70d112f5ad5 commit da230c6d9335b73af4acaaf110c9c70d112f5ad5 Author: Erik Clarizio <eclarizio@gmail.com> AuthorDate: Thu Jun 28 13:37:00 2018 -0400 Commit: Erik Clarizio <eclarizio@gmail.com> CommitDate: Thu Jun 28 13:37:00 2018 -0400 Refactor API failure logic into DialogUserSubmitErrorHandlerService https://bugzilla.redhat.com/show_bug.cgi?id=1591484 app/assets/javascripts/controllers/dialog_user/dialog_user_controller.js | 12 +- app/assets/javascripts/controllers/dialog_user/dialog_user_reconfigure_controller.js | 14 +- app/assets/javascripts/services/dialog_user_submit_error_handler_service.js | 13 + spec/javascripts/controllers/dialog_user/dialog_user_controller.spec.js | 39 +- spec/javascripts/services/dialog_user_submit_error_handling_service_spec.js | 41 + 5 files changed, 73 insertions(+), 46 deletions(-)
Steps : 1. Create a Generic Service 2. Specify an entry point for reconfigure(path doesn't matter) 3. Provision the Service 4. Reconfigure the Service to see if values specified in provisioning dialog are present. Dialog values are retained after reconfigure . Verified in 5.9.3.4.20180702181921_afd03d7
*** Bug 1433513 has been marked as a duplicate of this bug. ***
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:2184