Created attachment 1439780 [details] After reconfig
Hi Marianne, We're investigating the issue and will have an update soon. Thanks, Tina
Hi Yoder, Can you clarify the last point: - Does the same service dialog work for service provisioning in 4.6, and if so, does re-configuring the service work if the service was provisioned in your new 4.6 environment? -->New provisioning does populated all the field but unfortunately we were not able to fully provision any new VM and end up in error state after submitting request. ~~~ I understand that the customer is not successful doing VM provisioning. Can you ask them to: 1. Create a Generic Service 2. Specify an entry point for reconfigure(path doesn't matter) 3. Provision the Service 4. Reconfigure the Service to see if values specified in provisioning dialog are present. Thanks, Tina
*** Bug 1583775 has been marked as a duplicate of this bug. ***
This looks to be working on master, just fyi.
Verification blocked by https://bugzilla.redhat.com/show_bug.cgi?id=1588820
Created attachment 1449198 [details] dialog values Checking based on Tina's comment 6 . Given a reconfigure entry point . The dialog shows predefined values .The service name and description is not displayed as mentioned in the original issue . @tina : Please check if that is what is intended . 5.9.3.1.20180606184006_8d120c0. Appliance : https://10.8.199.164/ Service - ec2
I'm working on this. On Shveta's appliance I'm seeing that the values that show up are not always correct, which is interesting. If I order the service with different values than the ones that show up on dialog load, they will be wrong in the service reconfigure screen. I've also just opened this: https://github.com/ManageIQ/manageiq-ui-classic/issues/4119 because on every appliance since 5.7 the submit and cancel buttons have been missing but that's clearly a UI problem and needs a different ticket than this one.
https://github.com/ManageIQ/manageiq-ui-classic/pull/4140
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/108d88d84d84a763980f646d1bc9e9c77a7c70eb commit 108d88d84d84a763980f646d1bc9e9c77a7c70eb Author: Erik Clarizio <eclarizio> AuthorDate: Thu Jun 14 03:05:10 2018 -0400 Commit: Erik Clarizio <eclarizio> CommitDate: Thu Jun 14 03:05:10 2018 -0400 Ensure new dialog user component is used for service reconfiguration Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1580987 app/assets/javascripts/controllers/dialog_user/dialog_user_controller.js | 2 + app/controllers/service_controller.rb | 11 +- app/services/dialog_local_service.rb | 14 + spec/javascripts/controllers/dialog_user/dialog_user_controller.spec.js | 37 +- spec/services/dialog_local_service_spec.rb | 19 + 5 files changed, 76 insertions(+), 7 deletions(-)
https://github.com/ManageIQ/manageiq/pull/17647 https://github.com/ManageIQ/manageiq-ui-classic/pull/4226
New commits detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/fc78488e59a1e6e155eb530d8c4097600d21c705 commit fc78488e59a1e6e155eb530d8c4097600d21c705 Author: Erik Clarizio <eclarizi> AuthorDate: Wed Jun 27 20:33:20 2018 -0400 Commit: Erik Clarizio <eclarizi> CommitDate: Wed Jun 27 20:33:20 2018 -0400 Change reconfigure setup to include values configured with originally https://bugzilla.redhat.com/show_bug.cgi?id=1580987 app/models/dialog.rb | 12 + app/models/dialog_field.rb | 4 + app/models/dialog_field_sorted_item.rb | 10 +- app/models/resource_action_workflow.rb | 2 + app/models/service.rb | 10 + spec/models/dialog_field_drop_down_list_spec.rb | 57 - spec/models/dialog_field_radio_button_spec.rb | 96 - spec/models/dialog_field_sorted_item_spec.rb | 134 +- spec/models/dialog_field_spec.rb | 9 + spec/models/dialog_spec.rb | 37 + spec/models/resource_action_workflow_spec.rb | 9 + spec/models/service_spec.rb | 32 + 12 files changed, 126 insertions(+), 286 deletions(-) https://github.com/ManageIQ/manageiq/commit/71d857f93aa30ccc438b9df7a18e3c0766588a84 commit 71d857f93aa30ccc438b9df7a18e3c0766588a84 Author: Erik Clarizio <eclarizi> AuthorDate: Thu Jun 28 17:49:33 2018 -0400 Commit: Erik Clarizio <eclarizi> CommitDate: Thu Jun 28 17:49:33 2018 -0400 Ensure multi value default_value is set correctly for reconfigure https://bugzilla.redhat.com/show_bug.cgi?id=1580987 app/models/dialog_field_drop_down_list.rb | 5 + spec/models/dialog_field_drop_down_list_spec.rb | 19 + spec/models/dialog_field_sorted_item_spec.rb | 2 +- 3 files changed, 25 insertions(+), 1 deletion(-)
New commits detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/f11151dabbe1bf7182b18e614628a9c588940d2f commit f11151dabbe1bf7182b18e614628a9c588940d2f Author: Erik Clarizio <eclarizio> AuthorDate: Wed Jun 27 20:31:06 2018 -0400 Commit: Erik Clarizio <eclarizio> CommitDate: Wed Jun 27 20:31:06 2018 -0400 Change reconfigure setup to include values configured with originally https://bugzilla.redhat.com/show_bug.cgi?id=1580987 app/assets/javascripts/controllers/dialog_user/dialog_user_controller.js | 2 +- app/assets/javascripts/controllers/dialog_user/dialog_user_reconfigure_controller.js | 74 + app/controllers/application_controller/dialog_runner.rb | 3 + app/controllers/service_controller.rb | 28 +- app/services/dialog_local_service.rb | 14 - app/views/shared/dialogs/_reconfigure_dialog.html.haml | 25 + spec/controllers/service_controller_spec.rb | 29 + spec/services/dialog_local_service_spec.rb | 19 - 8 files changed, 144 insertions(+), 50 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/4b7bfdb8afbd804915f40b7bf85e72b867910a8b commit 4b7bfdb8afbd804915f40b7bf85e72b867910a8b Author: Erik Clarizio <eclarizio> AuthorDate: Thu Jun 28 13:37:00 2018 -0400 Commit: Erik Clarizio <eclarizio> CommitDate: Thu Jun 28 13:37:00 2018 -0400 Refactor API failure logic into DialogUserSubmitErrorHandlerService https://bugzilla.redhat.com/show_bug.cgi?id=1580987 app/assets/javascripts/controllers/dialog_user/dialog_user_controller.js | 12 +- app/assets/javascripts/controllers/dialog_user/dialog_user_reconfigure_controller.js | 14 +- app/assets/javascripts/services/dialog_user_submit_error_handler_service.js | 13 + spec/javascripts/controllers/dialog_user/dialog_user_controller.spec.js | 38 +- 4 files changed, 32 insertions(+), 45 deletions(-)
https://github.com/ManageIQ/manageiq-ui-classic/pull/4236
1. Create a Generic Service 2. Specify an entry point for reconfigure(path doesn't matter) 3. Provision the Service 4. Reconfigure the Service to see if values specified in provisioning dialog are present. Verified in 5.10.0.3.20180705151325_ce4d2b5