Bug 1598193 - Stale lock with lk-owner all-zeros is observed in some tests
Summary: Stale lock with lk-owner all-zeros is observed in some tests
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: 4.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On: 1597805
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-04 15:04 UTC by Pranith Kumar K
Modified: 2018-07-30 18:57 UTC (History)
1 user (show)

Fixed In Version: glusterfs-4.1.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1597805
Environment:
Last Closed: 2018-07-30 18:57:21 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Pranith Kumar K 2018-07-04 15:04:08 UTC
+++ This bug was initially created as a clone of Bug #1597805 +++

Description of problem:
    Problem:
    In the new eager-lock implementation lk-owner is assigned after the
    'local' is added to the eager-lock list, so there exists a possibility
    of lock being sent even before lk-owner is assigned.
    
    Fix:
    Make sure to assign lk-owner before adding local to eager-lock list


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2018-07-03 12:23:10 EDT ---

REVIEW: https://review.gluster.org/20455 (cluster/afr: Make sure lk-owner is assigned at the time of lock) posted (#1) for review on master by Pranith Kumar Karampuri

--- Additional comment from Worker Ant on 2018-07-04 10:39:05 EDT ---

COMMIT: https://review.gluster.org/20455 committed in master by "Pranith Kumar Karampuri" <pkarampu> with a commit message- cluster/afr: Make sure lk-owner is assigned at the time of lock

Problem:
In the new eager-lock implementation lk-owner is assigned after the
'local' is added to the eager-lock list, so there exists a possibility
of lock being sent even before lk-owner is assigned.

Fix:
Make sure to assign lk-owner before adding local to eager-lock list

fixes bz#1597805
Change-Id: I26d1b7bcf3e8b22531f1dc0b952cae2d92889ef2
Signed-off-by: Pranith Kumar K <pkarampu>

Comment 1 Worker Ant 2018-07-04 15:05:38 UTC
REVIEW: https://review.gluster.org/20459 (cluster/afr: Make sure lk-owner is assigned at the time of lock) posted (#1) for review on release-4.1 by Pranith Kumar Karampuri

Comment 2 Worker Ant 2018-07-09 15:16:37 UTC
COMMIT: https://review.gluster.org/20459 committed in release-4.1 by "Pranith Kumar Karampuri" <pkarampu> with a commit message- cluster/afr: Make sure lk-owner is assigned at the time of lock

Problem:
In the new eager-lock implementation lk-owner is assigned after the
'local' is added to the eager-lock list, so there exists a possibility
of lock being sent even before lk-owner is assigned.

Fix:
Make sure to assign lk-owner before adding local to eager-lock list

fixes bz#1598193
Change-Id: I26d1b7bcf3e8b22531f1dc0b952cae2d92889ef2
Signed-off-by: Pranith Kumar K <pkarampu>
(cherry picked from commit c6f93e422855f656d3a86461a8458f37ad0103eb)

Comment 3 Shyamsundar 2018-07-30 18:57:21 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.1.2, please open a new bug report.

glusterfs-4.1.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-July/000106.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.