Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1598909

Summary: No input validation on Add Subscriptions Page
Product: Red Hat Satellite Reporter: jcallaha
Component: Subscription ManagementAssignee: John Mitsch <jomitsch>
Status: CLOSED ERRATA QA Contact: jcallaha
Severity: high Docs Contact:
Priority: high    
Version: 6.4CC: cwelton, ehelms, tstrachota, zhunting
Target Milestone: 6.4.0Keywords: Triaged, UserExperience
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-katello-3.7.0-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-16 19:01:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description jcallaha 2018-07-06 20:21:47 UTC
Description of problem:
There currently are no input validations, when a user tries to add a new subscription. This means the user can submit any value. However, there seem to be two behaviors following submission of bad values. 
1. It appears to submit, then a warning pops up saying "No pools provided".
2. It actually submits the form, says it succeeded, then notifies of the task resulting in a warning state.

Version-Release number of selected component (if applicable):
Satellite 6.4 Snap 10

How reproducible:
Always

Steps to Reproduce:
1. Upload a valid manifest, that does not contain all the subscriptions in your account.
2. Navigate to subscriptions, the click "Add Subscriptions"
3. In one of the entitlement fields, enter any range of non-valid inputs.
4. If possible, try to submit the form.

Actual results:
There is no input validation, and the form submits, resulting in a failed task.

Expected results:
Input validation warns the user, and stops them from submitting bad data.

Comment 3 Corey Welton 2018-07-09 12:54:46 UTC
It should be noted that behavior #2 (which is more difficult to reliably reproduce) could potentially be causing issues deeper in the system, e.g., candlepin.

Comment 4 Walden Raines 2018-07-09 21:09:47 UTC
Created redmine issue https://projects.theforeman.org/issues/24215 from this bug

Comment 5 Satellite Program 2018-07-10 18:24:08 UTC
Upstream bug assigned to jomitsch

Comment 6 Brad Buckingham 2018-07-20 19:52:02 UTC
PR merged upstream.  Moving to POST.

Comment 7 jcallaha 2018-07-30 17:27:41 UTC
Verified in Satellite 6.4 Snap 14.

I followed my initial reproduction steps, trying a number of different invalid values. The ui caught each of the bad values while they were put in. Additionally, the submit button was disabled while invalid values were present.

See attached video for verification.

Comment 9 Walden Raines 2018-07-31 19:54:00 UTC
*** Bug 1599333 has been marked as a duplicate of this bug. ***

Comment 10 Bryan Kearney 2018-10-16 19:01:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2927