Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1608389

Summary: Multivalued options created with wrong syntax
Product: Red Hat OpenStack Reporter: David Juran <djuran>
Component: puppet-osloAssignee: Michele Baldessari <michele>
Status: CLOSED EOL QA Contact: nlevinki <nlevinki>
Severity: medium Docs Contact:
Priority: medium    
Version: 10.0 (Newton)CC: ansmith, chjones, chris.brown, djuran, jjoyce, jschluet, lmiccini, michele, moddi, mtenheuv, nnavarat, satmakur, schhabdi, slinaber, tvignaud
Target Milestone: ---Keywords: Triaged, ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2042429 (view as bug list) Environment:
Last Closed: 2021-07-07 10:36:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Juran 2018-07-25 12:32:36 UTC
Description of problem:
The keystone notification driver is a multivalued parameter, i.e. several drivers can be enabled. 

To do this from TripleO, I'm attempting 

KeystoneNotificationDriver:
    - messaging
    - log

According to the config format reference[1], the syntax in /etc/keystone.conf should be

[oslo_messaging_notifications]
driver = messaging
driver = log

However, the puppet module creates this as 
driver = messaging,log

This is not accepted by the keystone server

[1]
https://docs.openstack.org/newton/config-reference/config-format.html

Version-Release number of selected component (if applicable):
puppet-oslo-9.5.0-2.el7ost

Comment 4 Victor Stinner 2018-09-07 13:02:42 UTC
It seems like something is generating an incorrect configuration: "driver = messaging,log". puppet-oslo according to Andy Smith. The configuration should be written using multiple "driver = value" lines.

Comment 5 Michele Baldessari 2018-09-12 19:45:09 UTC
Ok so I looked at this a bit more. Via change https://review.openstack.org/#/c/481726/ we deprecated KeystoneNotificationDriver (which is a comma_delimited_list and which causes the issue in this BZ) in favour of NotificationDriver which is a string. The problem though seems to be that it was added as follows:
+  NotificationDriver:
+    type: string
+    default: 'messagingv2'
+    description: Driver or drivers to handle sending notifications.
+    constraints:
+      - allowed_values: [ 'messagingv2', 'noop' ]


So that will effectively force us to choose one over the other and cannot have both. David, before I chase a bunch of folks around this, I wanted to ask what the use case is around having multiple notification backends?

thanks,
Michele

Comment 8 David Juran 2019-01-28 14:50:28 UTC
Sorry, been away for while...

In reply to #5, one use case is when one e.g. enable CADF auditing. In many cases one then want the CADF events to go to the logs, to be picked up by the auditing framework in addition to the normal notifications which go to the message bus.

Comment 10 Michele Baldessari 2019-11-07 10:08:29 UTC
*** Bug 1767255 has been marked as a duplicate of this bug. ***

Comment 12 Luca Miccini 2020-03-03 15:30:05 UTC
we have few reviews lined up that still need a bit more work before they can be merged. we'll follow up on this topic asap.

Comment 22 Red Hat Bugzilla 2023-09-15 00:11:04 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days