Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1767255

Summary: puppet uses list value instead of multi-value for Oslo messaging notifications for driver option
Product: Red Hat OpenStack Reporter: NaveenRaj Navaratna Raj <nnavarat>
Component: puppet-osloAssignee: RHOS Maint <rhos-maint>
Status: CLOSED DUPLICATE QA Contact: nlevinki <nlevinki>
Severity: low Docs Contact:
Priority: low    
Version: 13.0 (Queens)CC: dsedgmen, jjoyce, jschluet, lmiccini, michele, slinaber, tvignaud
Target Milestone: ---Keywords: Triaged, ZStream
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-07 10:08:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description NaveenRaj Navaratna Raj 2019-10-31 02:13:50 UTC
Description of problem:

Value for notification driver is a list value. As per documentations it should be a multivalue.

#####################code ######################

less /usr/share/openstack-puppet/modules/oslo/manifests/messaging/notifications.pp
######################################
# == Define: oslo::messaging::notifications
#
# Configure oslo_messaging_notifications options
#
# This resource configures Oslo Notifications resources for an OpenStack service.
# It will manage the [oslo_messaging_notifications] section in the given config resource.
#
# === Parameters:
#
# [*driver*]
#   (Optional) The Driver(s) to handle sending notifications.
#   Possible values are messaging, messagingv2, routing, log, test, noop.
#   (list value)
#   Defaults to $::os_service_default.
#
# [*transport_url*]
#   (Optional) A URL representing the messaging driver to use for
#   notifications. If not set, we fall back to the same
#   configuration used for RPC.
#   Transport URLs take the form::
#      transport://user:pass@host1:port[,hostN:portN]/virtual_host
#   (string value)
#   Defaults to $::os_service_default.
#
# [*topics*]
#   (Optional) AMQP topic(s) used for OpenStack notifications
#   (list value)
#   Defaults to $::os_service_default.
#
define oslo::messaging::notifications(
  $driver        = $::os_service_default,
  $transport_url = $::os_service_default,
  $topics        = $::os_service_default,
) {
  if !is_service_default($driver) {
    $driver_orig = join(any2array($driver), ',')
  } else {
    $driver_orig = $driver
  }
 
  if !is_service_default($topics) {
    $topics_orig = join(any2array($topics), ',')
  } else {
    $topics_orig = $topics
  }
 
  $notification_options = {
    'oslo_messaging_notifications/driver'        => { value => $driver_orig },
    'oslo_messaging_notifications/transport_url' => { value => $transport_url, secret => true },
    'oslo_messaging_notifications/topics'        => { value => $topics_orig },
  }
 
  create_resources($name, $notification_options)
}
#####################End of code #######################


Version-Release number of selected component (if applicable):Queens


Actual results:
#############################################################
[oslo_messaging_notifications]
 
#
# From oslo.messaging
#
 
# The Drivers(s) to handle sending notifications. Possible values are
# messaging, messagingv2, routing, log, test, noop (multi valued)
# Deprecated group/name - [DEFAULT]/notification_driver
#driver =
driver=log,messagingv2

#############################################################
 
Expected results:

#############################################################
 
[oslo_messaging_notifications]
 
#
# From oslo.messaging
#
 
# The Drivers(s) to handle sending notifications. Possible values are
# messaging, messagingv2, routing, log, test, noop (multi valued)
# Deprecated group/name - [DEFAULT]/notification_driver
#driver =
driver=log
driver=messagingv2

#############################################################

Additional info:

https://docs.openstack.org/oslo.config/latest/configuration/format.html
https://docs.openstack.org/oslo.messaging/queens/configuration/opts.html

Comment 1 Luca Miccini 2019-11-04 06:52:22 UTC
we will try to have a look. Thanks for raising this.

Comment 2 Michele Baldessari 2019-11-07 10:08:29 UTC

*** This bug has been marked as a duplicate of bug 1608389 ***