Bug 1613242

I think this occurs because of a downstream-only change that we're carrying. That change is intended to work around the fact we don't currently rebuild an instance's XML (including pinning information) when live migrating. The patch checks to ensure the destination has the same free CPUs as the source and fails the migration if so. Clearly this filter should only be doing this for live migration and not cold migration, where the XML _is_ recalculated.

I don't see any clear evidence on how we can make differentiation between cold-migration and live-migration during the scheduling phase. I'm working on it to see what could be done.

I have a patc, Saravanan, can you make a try?


--- a/nova/scheduler/filters/numa_topology_filter.py
+++ b/nova/scheduler/filters/numa_topology_filter.py
@@ -13,6 +13,7 @@
 from oslo_log import log as logging
 import six
 
+from nova import context
 from nova import objects
 from nova.objects import fields
 from nova.scheduler import filters
@@ -21,9 +22,6 @@ from nova.virt import hardware
 LOG = logging.getLogger(__name__)
 
 
-LOG = logging.getLogger(__name__)
-
-
 class NUMATopologyFilter(filters.BaseHostFilter):
     """Filter on requested NUMA topology."""
 
@@ -96,25 +94,32 @@ class NUMATopologyFilter(filters.BaseHostFilter):
                 cpu_allocation_ratio=cpu_ratio,
                 ram_allocation_ratio=ram_ratio)
 
-            # Computing Host CPUs already pinned on the compute host to
-            # compare them to the requested by instance topology.
-            pinned_cpus = sum(
-                [list(c.pinned_cpus) for c in host_topology.cells], [])
-            LOG.debug("Host already pinned CPUs %s", pinned_cpus)
-            for cell in requested_topology.cells:
-                # To have the attribute cpu_pinning_raw set the
-                # instance has already been scheduled on a compute
-                # node and so its pinning information againsts Host
-                # CPUs computed and stored to the database.
-                if (cell.obj_attr_is_set('cpu_pinning_raw')
-                    and cell.cpu_pinning_raw):
-                    for vcpu, pcpu in six.iteritems(cell.cpu_pinning_raw):
-                        LOG.debug("vCPUs(%s) wants to be pinned on pCPUs(%s)",
-                                  vcpu, pcpu)
-                        if pcpu in pinned_cpus:
-                            LOG.debug("Can't move instance on host, "
-                                      "requested CPU %s already pinned", pcpu)
-                            return False
+            # Ensure that it's a live-migration
+            if objects.MigrationList.get_in_progress_by_instance(
+                    context.get_admin_context(),
+                    spec_obj.instance_uuid,
+                    "live-migration"):
+                # Computing Host CPUs already pinned on the compute host to
+                # compare them to the requested by instance topology.
+                pinned_cpus = sum(
+                    [list(c.pinned_cpus) for c in host_topology.cells], [])
+                LOG.debug("Host already pinned CPUs %s", pinned_cpus)
+                for cell in requested_topology.cells:
+                    # To have the attribute cpu_pinning_raw set the
+                    # instance has already been scheduled on a compute
+                    # node and so its pinning information againsts Host
+                    # CPUs computed and stored to the database.
+                    if (cell.obj_attr_is_set('cpu_pinning_raw')
+                        and cell.cpu_pinning_raw):
+                        for vcpu, pcpu in six.iteritems(cell.cpu_pinning_raw):
+                            LOG.debug("vCPUs(%s) wants to be pinned on "
+                                      "pCPUs(%s)",
+                                      vcpu, pcpu)
+                            if pcpu in pinned_cpus:
+                                LOG.debug("Can't move instance on host, "
+                                          "requested CPU %s already pinned",
+                                          pcpu)
+                                return False
 
             instance_topology = (hardware.numa_fit_instance_to_host(
                         host_topology, requested_topology,

Cold Migration works with NUMATopologyFilter with this patch.

ON the latest passed_phase1 puddle - puddle-id=2018-12-04.1
Cold migration tests have passed - https://rhos-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/DFG/view/nfv/view/nfv/job/DFG-nfv-10-director-hybrid-3cont-2comp-ipv4-vxlan-dpdk-sriov-ctlplane-dataplane-bonding-hybrid/13/testReport/nfv_tempest_plugin.tests.scenario.test_nfv_basic/TestNfvBasic/

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0074

*** Bug 1713530 has been marked as a duplicate of this bug. ***