Bug 1627200 - Fix ovirt-iso-uploader for python 3 compatibility
Summary: Fix ovirt-iso-uploader for python 3 compatibility
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-iso-uploader
Classification: oVirt
Component: Core
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.3.0
: ---
Assignee: Gal Zaidman
QA Contact: Sandro Bonazzola
URL:
Whiteboard:
: 1656046 (view as bug list)
Depends On:
Blocks: oVirt_on_Fedora
TreeView+ depends on / blocked
 
Reported: 2018-09-10 14:01 UTC by Sandro Bonazzola
Modified: 2019-02-13 07:45 UTC (History)
2 users (show)

Fixed In Version: ovirt-iso-uploader-4.3.0-1
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2019-02-13 07:45:13 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.3+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 94257 0 master ABANDONED WIP: Fedora 28 support 2020-02-19 12:31:43 UTC
oVirt gerrit 94701 0 master MERGED package for python2/3, and fix syntax changes 2020-02-19 12:31:43 UTC
oVirt gerrit 96131 0 master MERGED Packaging: remove python2/3 packages, and require the correct packages instead 2020-02-19 12:31:43 UTC

Description Sandro Bonazzola 2018-09-10 14:01:08 UTC
ovirt-iso-uploader is not python3 ready.

Comment 1 Sandro Bonazzola 2018-11-27 07:31:08 UTC
# dnf install ovirt-iso-uploader

Installing:
 ovirt-iso-uploader
Installing dependencies:
 python-ovirt-engine-sdk4
 python2-ovirt-iso-uploader

# dnf install python3-ovirt-iso-uploader
Installing:
 python3-ovirt-iso-uploader
Installing dependencies:
 python3-ovirt-engine-sdk4 

# rpm -ql python3-ovirt-iso-uploader
/etc/logrotate.d/ovirt-iso-uploader
/etc/ovirt-engine/isouploader.conf
/etc/ovirt-engine/isouploader.conf.d
/usr/bin/engine-iso-uploader
/usr/bin/ovirt-iso-uploader
/usr/lib/python3.6/site-packages/ovirt_iso_uploader
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__init__.py
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__main__.py
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/__init__.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/__init__.cpython-36.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/__main__.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/__main__.cpython-36.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/config.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/config.cpython-36.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/glfs_api.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/glfs_api.cpython-36.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/config.py
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/glfs_api.py
/usr/share/doc/python3-ovirt-iso-uploader
/usr/share/doc/python3-ovirt-iso-uploader/AUTHORS
/usr/share/licenses/python3-ovirt-iso-uploader
/usr/share/licenses/python3-ovirt-iso-uploader/COPYING
/usr/share/man/man8/engine-iso-uploader.8.gz
/usr/share/man/man8/ovirt-iso-uploader.8.gz
/var/log/ovirt-engine/ovirt-iso-uploader

# LC_ALL=C rpm -ql ovirt-iso-uploader
(contains no files)

Failing QA on ovirt-iso-uploader missing COPYING file, license file is required to be shipped in all rpms.
I would consider to package only python2 as single rpm on EL7 and package only python3 otherwise.
ovirt-iso-uploader is a binary, not a library. No real point in shipping both python2 and python3 on Fedora.

Comment 2 Red Hat Bugzilla Rules Engine 2018-11-27 07:31:13 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 3 Gal Zaidman 2018-12-11 08:48:13 UTC
*** Bug 1656046 has been marked as a duplicate of this bug. ***

Comment 4 Sandro Bonazzola 2019-01-23 10:42:44 UTC
# rpm -ql ovirt-iso-uploader
/etc/logrotate.d/ovirt-iso-uploader
/etc/ovirt-engine/isouploader.conf
/etc/ovirt-engine/isouploader.conf.d
/usr/bin/engine-iso-uploader
/usr/bin/ovirt-iso-uploader
/usr/lib/python3.6/site-packages/ovirt_iso_uploader
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__init__.py
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__main__.py
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/__init__.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/__init__.cpython-36.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/__main__.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/__main__.cpython-36.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/config.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/config.cpython-36.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/glfs_api.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/__pycache__/glfs_api.cpython-36.pyc
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/config.py
/usr/lib/python3.6/site-packages/ovirt_iso_uploader/glfs_api.py
/usr/share/doc/ovirt-iso-uploader
/usr/share/doc/ovirt-iso-uploader/AUTHORS
/usr/share/licenses/ovirt-iso-uploader
/usr/share/licenses/ovirt-iso-uploader/COPYING
/usr/share/man/man8/engine-iso-uploader.8.gz
/usr/share/man/man8/ovirt-iso-uploader.8.gz
/var/log/ovirt-engine/ovirt-iso-uploader

manual testing didn't raise any issue, looks good to me.

Comment 5 Sandro Bonazzola 2019-02-13 07:45:13 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.