Bug 1628240 - Missing word in provisioning mail's subject and body
Summary: Missing word in provisioning mail's subject and body
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Provisioning
Version: 5.10.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: GA
: 5.11.0
Assignee: William Fitzgerald
QA Contact: Jaroslav Henner
URL:
Whiteboard:
Depends On:
Blocks: 1672690
TreeView+ depends on / blocked
 
Reported: 2018-09-12 14:07 UTC by Jan Zmeskal
Modified: 2019-12-13 15:09 UTC (History)
9 users (show)

Fixed In Version: 5.11.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1672690 (view as bug list)
Environment:
Last Closed: 2019-12-13 15:09:33 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jan Zmeskal 2018-09-12 14:07:29 UTC
Description of problem:
When you receive an e-mail from CFME appliance that your VM provision request was not auto-approved, the subject of the e-mail looks like this:
"Request ID 1 - Virtual Machine Request from  Pending Approval."
There's obviously a word missing after "from".

Version-Release number of selected component (if applicable):
5.10.0.14

How reproducible:
100 %

Steps to Reproduce:
1. Have a CFME appliance with RHV as an infra provider.
2. Setup your appliance in a way that it will send you e-mails about VM provisioning requests.
3. Create a VM provision request that will *not* get auto-approved. For example you can auto-approve requests with VM count == 1, but not auto-approve any VM count above that.
4. Check the e-mails that are received by an approver.

Actual results:
An approver get an e-mail that has this subject:
"Request ID 1 - Virtual Machine Request from  Pending Approval."
Also, body of that mail says:
"Approver,


A Virtual Machine Request received from  is Pending."

As yo can see, there are two blank spaces after the work "from". In body as well as in subject. Also logic of the sentence implies that there's an information missing.

Additional info:
- Logs from CFME appliance are attached.
- I have not altered the original settings of automation domains.
- As far as I know, body of this e-mail is based on Automation domain ManageIQ -> System -> Notification -> Email -> InfrastructureMiqProvisionRequestApproverPending. But I might be mistaken there.
Anyway, if you inspect it, you can see that in the black space, ${/#miq_request.requester.email} should be displayed, but it is not. 
See here: https://url.corp.redhat.com/c53e51e

Comment 2 David Luong 2018-12-12 21:41:18 UTC
Opened PR: https://github.com/ManageIQ/manageiq-content/pull/484

Not sure if this is just a stop gap or if something in the backend isn't passing over miq_request.requester.email

Comment 3 Tina Fitzgerald 2019-01-14 21:52:00 UTC
Moving to POST since the PR in comment 2 has been merged.

Comment 6 Mike Shriver 2019-07-03 16:16:36 UTC
Tested in CFME  5.11.0.11.20190625161125_392c61e

The email subject for pending approval now includes the requester/owner email address.


Note You need to log in before you can comment on or make changes to this bug.